| Message ID | 20260621002305.3763752-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Laurent Pinchart (2026-06-21 01:23:02) > libcamera uses "typename" instead of "class" to denote template > parameter types. The vector class uses the latter, replace them with > "typename" for consistency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > include/libcamera/internal/vector.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h > index 093efafa8982..04ba5d847b7d 100644 > --- a/include/libcamera/internal/vector.h > +++ b/include/libcamera/internal/vector.h > @@ -263,7 +263,7 @@ public: > } > > private: > - template<class BinaryOp> > + template<typename BinaryOp> > static constexpr Vector apply(const Vector &lhs, const Vector &rhs, BinaryOp op) > { > Vector result; > @@ -274,7 +274,7 @@ private: > return result; > } > > - template<class U, class BinaryOp> > + template<typename U, typename BinaryOp> > static constexpr Vector apply(const Vector &lhs, U rhs, BinaryOp op) > { > Vector result; > @@ -285,7 +285,7 @@ private: > return result; > } > > - template<class BinaryOp> > + template<typename BinaryOp> > Vector &apply(const Vector &other, BinaryOp op) > { > auto itOther = other.data_.begin(); > @@ -295,7 +295,7 @@ private: > return *this; > } > > - template<class U, class BinaryOp> > + template<typename U, typename BinaryOp> > Vector &apply(U scalar, BinaryOp op) > { > std::for_each(data_.begin(), data_.end(), > -- > Regards, > > Laurent Pinchart >
2026. 06. 21. 2:23 keltezéssel, Laurent Pinchart írta: > libcamera uses "typename" instead of "class" to denote template > parameter types. The vector class uses the latter, replace them with > "typename" for consistency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > include/libcamera/internal/vector.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h > index 093efafa8982..04ba5d847b7d 100644 > --- a/include/libcamera/internal/vector.h > +++ b/include/libcamera/internal/vector.h > @@ -263,7 +263,7 @@ public: > } > > private: > - template<class BinaryOp> > + template<typename BinaryOp> > static constexpr Vector apply(const Vector &lhs, const Vector &rhs, BinaryOp op) > { > Vector result; > @@ -274,7 +274,7 @@ private: > return result; > } > > - template<class U, class BinaryOp> > + template<typename U, typename BinaryOp> > static constexpr Vector apply(const Vector &lhs, U rhs, BinaryOp op) > { > Vector result; > @@ -285,7 +285,7 @@ private: > return result; > } > > - template<class BinaryOp> > + template<typename BinaryOp> > Vector &apply(const Vector &other, BinaryOp op) > { > auto itOther = other.data_.begin(); > @@ -295,7 +295,7 @@ private: > return *this; > } > > - template<class U, class BinaryOp> > + template<typename U, typename BinaryOp> > Vector &apply(U scalar, BinaryOp op) > { > std::for_each(data_.begin(), data_.end(),
diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h index 093efafa8982..04ba5d847b7d 100644 --- a/include/libcamera/internal/vector.h +++ b/include/libcamera/internal/vector.h @@ -263,7 +263,7 @@ public: } private: - template<class BinaryOp> + template<typename BinaryOp> static constexpr Vector apply(const Vector &lhs, const Vector &rhs, BinaryOp op) { Vector result; @@ -274,7 +274,7 @@ private: return result; } - template<class U, class BinaryOp> + template<typename U, typename BinaryOp> static constexpr Vector apply(const Vector &lhs, U rhs, BinaryOp op) { Vector result; @@ -285,7 +285,7 @@ private: return result; } - template<class BinaryOp> + template<typename BinaryOp> Vector &apply(const Vector &other, BinaryOp op) { auto itOther = other.data_.begin(); @@ -295,7 +295,7 @@ private: return *this; } - template<class U, class BinaryOp> + template<typename U, typename BinaryOp> Vector &apply(U scalar, BinaryOp op) { std::for_each(data_.begin(), data_.end(),
libcamera uses "typename" instead of "class" to denote template parameter types. The vector class uses the latter, replace them with "typename" for consistency. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/libcamera/internal/vector.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)