[v1] egl: Log the GL-driver
diff mbox series

Message ID 20260616112021.51712-1-robert.mader@collabora.com
State New
Headers show
Series
  • [v1] egl: Log the GL-driver
Related show

Commit Message

Robert Mader June 16, 2026, 11:20 a.m. UTC 
To make it easier to differentiate various drivers. Some examples from running on
a FairPhone5:

INFO eGL egl.cpp:362 EGL: GL_RENDERER: FD643
INFO eGL egl.cpp:362 EGL: GL_RENDERER: llvmpipe (LLVM 22.1.3, 128 bits)
INFO eGL egl.cpp:362 EGL: GL_RENDERER: zink Vulkan 1.3(Turnip Adreno (TM) 643 (MESA_TURNIP))

Signed-off-by: Robert Mader <robert.mader@collabora.com>
---
 src/libcamera/egl.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham June 16, 2026, 11:38 a.m. UTC | #1 
Quoting Robert Mader (2026-06-16 12:20:21)
> To make it easier to differentiate various drivers. Some examples from running on
> a FairPhone5:
> 
> INFO eGL egl.cpp:362 EGL: GL_RENDERER: FD643
> INFO eGL egl.cpp:362 EGL: GL_RENDERER: llvmpipe (LLVM 22.1.3, 128 bits)
> INFO eGL egl.cpp:362 EGL: GL_RENDERER: zink Vulkan 1.3(Turnip Adreno (TM) 643 (MESA_TURNIP))
> 
> Signed-off-by: Robert Mader <robert.mader@collabora.com>

I can see how that would be useful.

I'm not sure if they would always be Info level, but as the GL_VERSION
is at Info, I think this one can be too, changing the level can be a
future topic if we ever need to reduce noise here but I think it's fine:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/egl.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
> index c185bb7ad..1479df8b4 100644
> --- a/src/libcamera/egl.cpp
> +++ b/src/libcamera/egl.cpp
> @@ -359,6 +359,7 @@ int eGL::initEGLContext()
>  
>         makeCurrent();
>  
> +       LOG(eGL, Info) << "EGL: GL_RENDERER: " << glGetString(GL_RENDERER);
>         LOG(eGL, Info) << "EGL: GL_VERSION: " << glGetString(GL_VERSION);
>  
>         return 0;
> -- 
> 2.54.0
>
Jai Luthra June 16, 2026, 11:46 a.m. UTC | #2 
Hi Robert,

Quoting Robert Mader (2026-06-16 16:50:21)
> To make it easier to differentiate various drivers. Some examples from running on
> a FairPhone5:
> 
> INFO eGL egl.cpp:362 EGL: GL_RENDERER: FD643
> INFO eGL egl.cpp:362 EGL: GL_RENDERER: llvmpipe (LLVM 22.1.3, 128 bits)
> INFO eGL egl.cpp:362 EGL: GL_RENDERER: zink Vulkan 1.3(Turnip Adreno (TM) 643 (MESA_TURNIP))
> 
> Signed-off-by: Robert Mader <robert.mader@collabora.com>

Thank you for the patch, it's quite useful on my beagle play as well to
know if I'm accidently running llvmpipe instead of the GPU.

Tested-by: Jai Luthra <jai.luthra@ideasonboard.com>
Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>

Cheers,
    Jai

> ---
>  src/libcamera/egl.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
> index c185bb7ad..1479df8b4 100644
> --- a/src/libcamera/egl.cpp
> +++ b/src/libcamera/egl.cpp
> @@ -359,6 +359,7 @@ int eGL::initEGLContext()
>  
>         makeCurrent();
>  
> +       LOG(eGL, Info) << "EGL: GL_RENDERER: " << glGetString(GL_RENDERER);
>         LOG(eGL, Info) << "EGL: GL_VERSION: " << glGetString(GL_VERSION);
>  
>         return 0;
> -- 
> 2.54.0
>
Laurent Pinchart June 16, 2026, 1:28 p.m. UTC | #3 
On Tue, Jun 16, 2026 at 12:38:34PM +0100, Kieran Bingham wrote:
> Quoting Robert Mader (2026-06-16 12:20:21)
> > To make it easier to differentiate various drivers. Some examples from running on
> > a FairPhone5:
> > 
> > INFO eGL egl.cpp:362 EGL: GL_RENDERER: FD643
> > INFO eGL egl.cpp:362 EGL: GL_RENDERER: llvmpipe (LLVM 22.1.3, 128 bits)
> > INFO eGL egl.cpp:362 EGL: GL_RENDERER: zink Vulkan 1.3(Turnip Adreno (TM) 643 (MESA_TURNIP))
> > 
> > Signed-off-by: Robert Mader <robert.mader@collabora.com>
> 
> I can see how that would be useful.
> 
> I'm not sure if they would always be Info level, but as the GL_VERSION
> is at Info, I think this one can be too, changing the level can be a
> future topic if we ever need to reduce noise here but I think it's fine:

There's lots of logging that should be refactored in the soft ISP (I'm
thinking in particular about how we log the whole shader source). This
patch doesn't make the situation significantly worse, so it's fine for
now.

> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> > ---
> >  src/libcamera/egl.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
> > index c185bb7ad..1479df8b4 100644
> > --- a/src/libcamera/egl.cpp
> > +++ b/src/libcamera/egl.cpp
> > @@ -359,6 +359,7 @@ int eGL::initEGLContext()
> >  
> >         makeCurrent();
> >  
> > +       LOG(eGL, Info) << "EGL: GL_RENDERER: " << glGetString(GL_RENDERER);
> >         LOG(eGL, Info) << "EGL: GL_VERSION: " << glGetString(GL_VERSION);
> >  
> >         return 0;

Patch
diff mbox series 

diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
index c185bb7ad..1479df8b4 100644
--- a/src/libcamera/egl.cpp
+++ b/src/libcamera/egl.cpp
@@ -359,6 +359,7 @@  int eGL::initEGLContext()
 
 	makeCurrent();
 
+	LOG(eGL, Info) << "EGL: GL_RENDERER: " << glGetString(GL_RENDERER);
 	LOG(eGL, Info) << "EGL: GL_VERSION: " << glGetString(GL_VERSION);
 
 	return 0;