| Message ID | 20260327-ov08d10-v1-1-b08eec3e1d21@emfend.at |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series |
|
| Related | show |
Hi Matthias, Thank you for the patch, and sorry for the late reply. We've experimenting with a new patchwork janitor process that should avoid patches falling through the cracks, but processing the backlog will take some time. On Fri, Mar 27, 2026 at 12:22:22PM +0100, Matthias Fend wrote: > Provide the OmniVision OV08D10 camera sensor properties and registration > with libipa for the gain code helpers. > > Signed-off-by: Matthias Fend <matthias.fend@emfend.at> > --- > src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++ > src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index e3e3e535541384ba862ba2045114a69db7efff34..4d7e5b01004c707b9871da69ad1139bb79f2402d 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -653,6 +653,16 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708) > > +class CameraSensorHelperOv08d10 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperOv08d10() > + { Could you please add the black level too ? > + gain_ = AnalogueGainLinear{ 1, 0, 0, 128 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("ov08d10", CameraSensorHelperOv08d10) > + > class CameraSensorHelperOv2685 : public CameraSensorHelper > { > public: > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp > index b217363d872a7cee81fbf50242e13cf0f6819da5..0e346edac66c7b85650b0e7c30496f1f10ab445e 100644 > --- a/src/libcamera/sensor/camera_sensor_properties.cpp > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp > @@ -325,6 +325,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > .hblankDelay = 3 > }, > } }, > + { "ov08d10", { > + .unitCellSize = { 1120, 1120 }, > + .testPatternModes = { > + { controls::draft::TestPatternModeOff, 0 }, > + { controls::draft::TestPatternModeCustom1, 1 }, > + }, > + .sensorDelays = { > + .exposureDelay = 2, > + .gainDelay = 2, > + .vblankDelay = 2, > + .hblankDelay = 2 > + }, > + } }, > { "ov2685", { > .unitCellSize = { 1750, 1750 }, > .testPatternModes = { > > --- > base-commit: 4937f5489b799e1ce5b0856cc34549abacb1f19a > change-id: 20260327-ov08d10-078ce984b8a4
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index e3e3e535541384ba862ba2045114a69db7efff34..4d7e5b01004c707b9871da69ad1139bb79f2402d 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -653,6 +653,16 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708) +class CameraSensorHelperOv08d10 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv08d10() + { + gain_ = AnalogueGainLinear{ 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov08d10", CameraSensorHelperOv08d10) + class CameraSensorHelperOv2685 : public CameraSensorHelper { public: diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp index b217363d872a7cee81fbf50242e13cf0f6819da5..0e346edac66c7b85650b0e7c30496f1f10ab445e 100644 --- a/src/libcamera/sensor/camera_sensor_properties.cpp +++ b/src/libcamera/sensor/camera_sensor_properties.cpp @@ -325,6 +325,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .hblankDelay = 3 }, } }, + { "ov08d10", { + .unitCellSize = { 1120, 1120 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeCustom1, 1 }, + }, + .sensorDelays = { + .exposureDelay = 2, + .gainDelay = 2, + .vblankDelay = 2, + .hblankDelay = 2 + }, + } }, { "ov2685", { .unitCellSize = { 1750, 1750 }, .testPatternModes = {
Provide the OmniVision OV08D10 camera sensor properties and registration with libipa for the gain code helpers. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++ src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++ 2 files changed, 23 insertions(+) --- base-commit: 4937f5489b799e1ce5b0856cc34549abacb1f19a change-id: 20260327-ov08d10-078ce984b8a4 Best regards,