LF-18392 libcamera: software_isp: debayer_egl: Demote unsupported format log to Debug

26813 diff mbox series

From: Hou Qi <qi.hou@nxp.com>

DebayerEGL::getInputConfig() logs at Error level when it encounters an
unsupported input format. This function is called during format
enumeration from the simple pipeline handler's tryPipeline(), which
iterates over all pixel formats reported by the video capture device,
including non-Bayer formats such as UYVY and YUYV. The caller already
handles the failure gracefully by checking the return value and falling
back to direct passthrough when the debayer returns no output formats.

Since encountering a non-Bayer format during enumeration is expected
behaviour rather than an error condition, demote the log message from
Error to Debug. This aligns with DebayerCpu::getInputConfig(), which
logs at Info level in the same situation.

Signed-off-by: Qi Hou <qi.hou@nxp.com>
---
 src/libcamera/software_isp/debayer_egl.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Qi,

I think we can drop "LF-18392" in the $SUBJECT, but that could be while
applying if nothing else is needed.


Quoting Qi Hou (2026-06-01 10:28:06)
> From: Hou Qi <qi.hou@nxp.com>
> 
> DebayerEGL::getInputConfig() logs at Error level when it encounters an
> unsupported input format. This function is called during format
> enumeration from the simple pipeline handler's tryPipeline(), which
> iterates over all pixel formats reported by the video capture device,
> including non-Bayer formats such as UYVY and YUYV. The caller already
> handles the failure gracefully by checking the return value and falling
> back to direct passthrough when the debayer returns no output formats.
> 
> Since encountering a non-Bayer format during enumeration is expected
> behaviour rather than an error condition, demote the log message from
> Error to Debug. This aligns with DebayerCpu::getInputConfig(), which
> logs at Info level in the same situation.

I've been 'annoyed' by this print quite a bit too, so I also favour
reducing the output.

I think originally we wanted to be sure we saw if the formats weren't
supported, but indeed this is currently very verbose at startup.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Signed-off-by: Qi Hou <qi.hou@nxp.com>
> ---
>  src/libcamera/software_isp/debayer_egl.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp
> index 8f0c229f..1bd1efae 100644
> --- a/src/libcamera/software_isp/debayer_egl.cpp
> +++ b/src/libcamera/software_isp/debayer_egl.cpp
> @@ -73,7 +73,7 @@ int DebayerEGL::getInputConfig(PixelFormat inputFormat, DebayerInputConfig &conf
>                 return 0;
>         }
>  
> -       LOG(Debayer, Error)
> +       LOG(Debayer, Debug)
>                 << "Unsupported input format " << inputFormat;
>  
>         return -EINVAL;
> -- 
> 2.34.1
>

Hi Kieran Bingham,

Thank you very much for your quick review. I have sent out the new patch.
In v2, I have dropped "LF-18392" in the $SUBJECT, and change the log level from Error to Info for both DebayerEGL::getInputConfig() and DebayerEGL::getOutputConfig() for consistency with DebayerCpu.

Regards,
Qi Hou

-----Original Message-----
From: Kieran Bingham <kieran.bingham@ideasonboard.com> 
Sent: Monday, June 1, 2026 5:53 PM
To: Qi Hou <qi.hou@nxp.com>; libcamera-devel@lists.libcamera.org
Cc: nicolas@ndufresne.ca; Jared Hu <jared.hu@nxp.com>; Qi Hou <qi.hou@nxp.com>; Julien Vuillaumier <julien.vuillaumier@nxp.com>
Subject: [EXT] Re: [PATCH] LF-18392 libcamera: software_isp: debayer_egl: Demote unsupported format log to Debug

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button


Hi Qi,

I think we can drop "LF-18392" in the $SUBJECT, but that could be while applying if nothing else is needed.


Quoting Qi Hou (2026-06-01 10:28:06)
> From: Hou Qi <qi.hou@nxp.com>
>
> DebayerEGL::getInputConfig() logs at Error level when it encounters an 
> unsupported input format. This function is called during format 
> enumeration from the simple pipeline handler's tryPipeline(), which 
> iterates over all pixel formats reported by the video capture device, 
> including non-Bayer formats such as UYVY and YUYV. The caller already 
> handles the failure gracefully by checking the return value and 
> falling back to direct passthrough when the debayer returns no output formats.
>
> Since encountering a non-Bayer format during enumeration is expected 
> behaviour rather than an error condition, demote the log message from 
> Error to Debug. This aligns with DebayerCpu::getInputConfig(), which 
> logs at Info level in the same situation.

I've been 'annoyed' by this print quite a bit too, so I also favour reducing the output.

I think originally we wanted to be sure we saw if the formats weren't supported, but indeed this is currently very verbose at startup.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>
> Signed-off-by: Qi Hou <qi.hou@nxp.com>
> ---
>  src/libcamera/software_isp/debayer_egl.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/software_isp/debayer_egl.cpp 
> b/src/libcamera/software_isp/debayer_egl.cpp
> index 8f0c229f..1bd1efae 100644
> --- a/src/libcamera/software_isp/debayer_egl.cpp
> +++ b/src/libcamera/software_isp/debayer_egl.cpp
> @@ -73,7 +73,7 @@ int DebayerEGL::getInputConfig(PixelFormat inputFormat, DebayerInputConfig &conf
>                 return 0;
>         }
>
> -       LOG(Debayer, Error)
> +       LOG(Debayer, Debug)
>                 << "Unsupported input format " << inputFormat;
>
>         return -EINVAL;
> --
> 2.34.1
>