[v5,4/4] libcamera: software_isp: Explicitly load "simple" IPA
diff mbox series

Message ID 20260512175340.115153-5-johannes.goede@oss.qualcomm.com
State New
Headers show
Series
  • ipa: Allow IPA creation by name
Related show

Commit Message

Hans de Goede May 12, 2026, 5:53 p.m. UTC 
Explicitly specify the "simple" IPA name when loading the IPA so that
the softISP can be used with other pipeline-handlers too.

Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
 src/libcamera/software_isp/software_isp.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi May 13, 2026, 2:50 p.m. UTC | #1 
Hi Hans

On Tue, May 12, 2026 at 07:53:40PM +0200, Hans de Goede wrote:
> Explicitly specify the "simple" IPA name when loading the IPA so that
> the softISP can be used with other pipeline-handlers too.
>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Just to complete the series' review
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
>  src/libcamera/software_isp/software_isp.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index 781cf02f8..4f30aa180 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -129,7 +129,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
>  	debayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);
>  	debayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);
>
> -	ipa_ = pipe->createIPA<ipa::soft::IPAProxySoft>(0, 0);
> +	ipa_ = pipe->createIPA<ipa::soft::IPAProxySoft>("simple", 0, 0);
>  	if (!ipa_) {
>  		LOG(SoftwareIsp, Error)
>  			<< "Creating IPA for software ISP failed";
> --
> 2.54.0
>
Barnabás Pőcze May 13, 2026, 3:22 p.m. UTC | #2 
2026. 05. 12. 19:53 keltezéssel, Hans de Goede írta:
> Explicitly specify the "simple" IPA name when loading the IPA so that
> the softISP can be used with other pipeline-handlers too.
> 
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/libcamera/software_isp/software_isp.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index 781cf02f8..4f30aa180 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -129,7 +129,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
>   	debayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);
>   	debayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);
>   
> -	ipa_ = pipe->createIPA<ipa::soft::IPAProxySoft>(0, 0);
> +	ipa_ = pipe->createIPA<ipa::soft::IPAProxySoft>("simple", 0, 0);
>   	if (!ipa_) {
>   		LOG(SoftwareIsp, Error)
>   			<< "Creating IPA for software ISP failed";

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
index 781cf02f8..4f30aa180 100644
--- a/src/libcamera/software_isp/software_isp.cpp
+++ b/src/libcamera/software_isp/software_isp.cpp
@@ -129,7 +129,7 @@  SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
 	debayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);
 	debayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);
 
-	ipa_ = pipe->createIPA<ipa::soft::IPAProxySoft>(0, 0);
+	ipa_ = pipe->createIPA<ipa::soft::IPAProxySoft>("simple", 0, 0);
 	if (!ipa_) {
 		LOG(SoftwareIsp, Error)
 			<< "Creating IPA for software ISP failed";