| Message ID | 20200227200407.490616-28-nicolas.dufresne@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Nicolas, Thank you for the patch. On Thu, Feb 27, 2020 at 03:04:07PM -0500, Nicolas Dufresne wrote: > This has been tested to build and run on 1.14, except for the device monitor. > Mostly, all device monitors that are non-monitoring have been broken for a long > time. Does that mean we'll need v1.16 when we'll implement hotplug support, or that it will work fine on v1.14 ? > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> You may even want to squash this in patch 01/27. > --- > src/gstreamer/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build > index 90773af..269b8b6 100644 > --- a/src/gstreamer/meson.build > +++ b/src/gstreamer/meson.build > @@ -13,7 +13,7 @@ libcamera_gst_c_args = [ > '-DPACKAGE="@0@"'.format(meson.project_name()), > ] > > -gst_req = '>=1.16.1' > +gst_req = '>=1.14.0' > gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req, > required : get_option('gstreamer')) > gstallocator_dep = dependency('gstreamer-allocators-1.0', version : gst_req,
Le samedi 29 février 2020 à 17:12 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > Thank you for the patch. > > On Thu, Feb 27, 2020 at 03:04:07PM -0500, Nicolas Dufresne wrote: > > This has been tested to build and run on 1.14, except for the device monitor. > > Mostly, all device monitors that are non-monitoring have been broken for a long > > time. > > Does that mean we'll need v1.16 when we'll implement hotplug support, or > that it will work fine on v1.14 ? The situation for device probes is complicated. A dev messed in 1.15 and backported that. Of course this was not covered by the CI. The regressions started in 1.14, and are broken differently in 1.16 (the fix for the regression broke other stuff). In theory it all worked in 1.12. So I have no idea what will happen, but I'm tempted to ignore this, it's GStreamer problem. > > > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > You may even want to squash this in patch 01/27. Ok. > > > --- > > src/gstreamer/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build > > index 90773af..269b8b6 100644 > > --- a/src/gstreamer/meson.build > > +++ b/src/gstreamer/meson.build > > @@ -13,7 +13,7 @@ libcamera_gst_c_args = [ > > '-DPACKAGE="@0@"'.format(meson.project_name()), > > ] > > > > -gst_req = '>=1.16.1' > > +gst_req = '>=1.14.0' > > gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req, > > required : get_option('gstreamer')) > > gstallocator_dep = dependency('gstreamer-allocators-1.0', version : gst_req,
diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build index 90773af..269b8b6 100644 --- a/src/gstreamer/meson.build +++ b/src/gstreamer/meson.build @@ -13,7 +13,7 @@ libcamera_gst_c_args = [ '-DPACKAGE="@0@"'.format(meson.project_name()), ] -gst_req = '>=1.16.1' +gst_req = '>=1.14.0' gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req, required : get_option('gstreamer')) gstallocator_dep = dependency('gstreamer-allocators-1.0', version : gst_req,
This has been tested to build and run on 1.14, except for the device monitor. Mostly, all device monitors that are non-monitoring have been broken for a long time. Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> --- src/gstreamer/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)