| Message ID | 20260216203034.27558-2-mzamazal@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi, On 16-Feb-26 9:30 PM, Milan Zamazal wrote: > It is not used anywhere in software_isp.h. > > Signed-off-by: Milan Zamazal <mzamazal@redhat.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com> This should probably be merged independently of this series (can be merged right away). Regards, Hans > --- > include/libcamera/internal/software_isp/software_isp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h > index ad89c9b3c..2ec14a3c7 100644 > --- a/include/libcamera/internal/software_isp/software_isp.h > +++ b/include/libcamera/internal/software_isp/software_isp.h > @@ -9,7 +9,6 @@ > > #include <deque> > #include <functional> > -#include <initializer_list> > #include <map> > #include <memory> > #include <stdint.h>
Hi Hans, thank you for review. johannes.goede@oss.qualcomm.com writes: > Hi, > > On 16-Feb-26 9:30 PM, Milan Zamazal wrote: >> It is not used anywhere in software_isp.h. >> >> Signed-off-by: Milan Zamazal <mzamazal@redhat.com> > > Thanks, patch looks good to me: > > Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com> > > This should probably be merged independently of this series (can be merged right away). After further inspection, I've found out there are more problems with #include's in software ISP. Posted as a separate patch to fix them all. > Regards, > > Hans > > >> --- >> include/libcamera/internal/software_isp/software_isp.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h >> index ad89c9b3c..2ec14a3c7 100644 >> --- a/include/libcamera/internal/software_isp/software_isp.h >> +++ b/include/libcamera/internal/software_isp/software_isp.h >> @@ -9,7 +9,6 @@ >> >> #include <deque> >> #include <functional> >> -#include <initializer_list> >> #include <map> >> #include <memory> >> #include <stdint.h>
diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h index ad89c9b3c..2ec14a3c7 100644 --- a/include/libcamera/internal/software_isp/software_isp.h +++ b/include/libcamera/internal/software_isp/software_isp.h @@ -9,7 +9,6 @@ #include <deque> #include <functional> -#include <initializer_list> #include <map> #include <memory> #include <stdint.h>
It is not used anywhere in software_isp.h. Signed-off-by: Milan Zamazal <mzamazal@redhat.com> --- include/libcamera/internal/software_isp/software_isp.h | 1 - 1 file changed, 1 deletion(-)