[v1,3/3] libcamera: software_isp: debayer_egl: Remove unnecessary declarations
diff mbox series

Message ID 20260413114713.426459-3-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • [v1,1/3] libcamera: egl: Remove `eGLImage::image_`
Related show

Commit Message

Barnabás Pőcze April 13, 2026, 11:47 a.m. UTC 
These functions are not defined, so remove them.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/software_isp/debayer_egl.h | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Kieran Bingham April 13, 2026, 1:13 p.m. UTC | #1 
Quoting Barnabás Pőcze (2026-04-13 12:47:13)
> These functions are not defined, so remove them.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/software_isp/debayer_egl.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h
> index d563bfa55..644f6604e 100644
> --- a/src/libcamera/software_isp/debayer_egl.h
> +++ b/src/libcamera/software_isp/debayer_egl.h
> @@ -61,18 +61,9 @@ public:
>  private:
>         static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);
>         static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);
> -       int setupStandardBayerOrder(BayerFormat::Order order);
> -       void pushEnv(std::vector<std::string> &shaderEnv, const char *str);
>         int initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);
> -       int initEGLContext();
> -       int generateTextures();
> -       int compileShaderProgram(GLuint &shaderId, GLenum shaderType,
> -                                unsigned char *shaderData, int shaderDataLen,
> -                                std::vector<std::string> shaderEnv);
> -       int linkShaderProgram(void);
>         int getShaderVariableLocations();
>         void setShaderVariableValues(const DebayerParams &params);
> -       void configureTexture(GLuint &texture);
>         int debayerGPU(MappedFrameBuffer &in, int out_fd, const DebayerParams &params);
>  
>         /* Shader program identifiers */
> -- 
> 2.53.0
>

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h
index d563bfa55..644f6604e 100644
--- a/src/libcamera/software_isp/debayer_egl.h
+++ b/src/libcamera/software_isp/debayer_egl.h
@@ -61,18 +61,9 @@  public:
 private:
 	static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);
 	static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);
-	int setupStandardBayerOrder(BayerFormat::Order order);
-	void pushEnv(std::vector<std::string> &shaderEnv, const char *str);
 	int initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);
-	int initEGLContext();
-	int generateTextures();
-	int compileShaderProgram(GLuint &shaderId, GLenum shaderType,
-				 unsigned char *shaderData, int shaderDataLen,
-				 std::vector<std::string> shaderEnv);
-	int linkShaderProgram(void);
 	int getShaderVariableLocations();
 	void setShaderVariableValues(const DebayerParams &params);
-	void configureTexture(GLuint &texture);
 	int debayerGPU(MappedFrameBuffer &in, int out_fd, const DebayerParams &params);
 
 	/* Shader program identifiers */