| Message ID | 20260405213349.1224164-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent On Mon, Apr 06, 2026 at 12:33:48AM +0300, Laurent Pinchart wrote: > All boolean options in libcamera other than the soft ISP options are > printed as YES/NO (with colours when supported by the terminal). Extend > this to the soft ISP options for consistency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/libcamera/software_isp/meson.build | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build > index 7a2f704bf158..15f9e4032dc1 100644 > --- a/src/libcamera/software_isp/meson.build > +++ b/src/libcamera/software_isp/meson.build > @@ -1,7 +1,9 @@ > # SPDX-License-Identifier: CC0-1.0 > > softisp_enabled = pipelines.contains('simple') > -summary({'SoftISP support' : softisp_enabled}, section : 'Configuration') > +summary({'SoftISP support' : softisp_enabled}, > + bool_yn : true, > + section : 'Configuration') > > if not softisp_enabled > subdir_done() > @@ -13,7 +15,9 @@ mesa_works = cc.check_header('EGL/egl.h', > required : get_option('softisp-gpu'), > dependencies : libegl) > > -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration') > +summary({'SoftISP GPU acceleration' : mesa_works}, > + bool_yn : true, > + section : 'Configuration') > > libcamera_internal_sources += files([ > 'benchmark.cpp', > -- > Regards, > > Laurent Pinchart >
2026. 04. 05. 23:33 keltezéssel, Laurent Pinchart írta: > All boolean options in libcamera other than the soft ISP options are > printed as YES/NO (with colours when supported by the terminal). Extend > this to the soft ISP options for consistency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/libcamera/software_isp/meson.build | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build > index 7a2f704bf158..15f9e4032dc1 100644 > --- a/src/libcamera/software_isp/meson.build > +++ b/src/libcamera/software_isp/meson.build > @@ -1,7 +1,9 @@ > # SPDX-License-Identifier: CC0-1.0 > > softisp_enabled = pipelines.contains('simple') > -summary({'SoftISP support' : softisp_enabled}, section : 'Configuration') > +summary({'SoftISP support' : softisp_enabled}, > + bool_yn : true, > + section : 'Configuration') > > if not softisp_enabled > subdir_done() > @@ -13,7 +15,9 @@ mesa_works = cc.check_header('EGL/egl.h', > required : get_option('softisp-gpu'), > dependencies : libegl) > > -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration') > +summary({'SoftISP GPU acceleration' : mesa_works}, > + bool_yn : true, > + section : 'Configuration') > > libcamera_internal_sources += files([ > 'benchmark.cpp',
diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build index 7a2f704bf158..15f9e4032dc1 100644 --- a/src/libcamera/software_isp/meson.build +++ b/src/libcamera/software_isp/meson.build @@ -1,7 +1,9 @@ # SPDX-License-Identifier: CC0-1.0 softisp_enabled = pipelines.contains('simple') -summary({'SoftISP support' : softisp_enabled}, section : 'Configuration') +summary({'SoftISP support' : softisp_enabled}, + bool_yn : true, + section : 'Configuration') if not softisp_enabled subdir_done() @@ -13,7 +15,9 @@ mesa_works = cc.check_header('EGL/egl.h', required : get_option('softisp-gpu'), dependencies : libegl) -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration') +summary({'SoftISP GPU acceleration' : mesa_works}, + bool_yn : true, + section : 'Configuration') libcamera_internal_sources += files([ 'benchmark.cpp',
All boolean options in libcamera other than the soft ISP options are printed as YES/NO (with colours when supported by the terminal). Extend this to the soft ISP options for consistency. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/software_isp/meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)