| Message ID | 20260330-kbingham-pipeline-handler-property-v1-1-fdab13d5d263@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran On Mon, Mar 30, 2026 at 12:40:24PM +0100, Kieran Bingham wrote: > Allow the camera properties to report what pipeline handler is managing > the camera device. > As you pointed out, the same platform could be supported by different pipeline handlers, so I think this actually makes sense. However I wonder how an application is supposed to use this property, this seems more like something useful during development/experimentation > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> But overall I don't see any drawback in adding such property, so Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/libcamera/property_ids_core.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml > index 834454a4e087..524cc48a08c7 100644 > --- a/src/libcamera/property_ids_core.yaml > +++ b/src/libcamera/property_ids_core.yaml > @@ -701,4 +701,9 @@ controls: > > Different cameras may report identical devices. > > + - PipelineHandler: > + type: string > + description: | > + The name of the pipeline handler that manages this camera device. > + > ... > > -- > 2.52.0 >
2026. 04. 02. 12:06 keltezéssel, Jacopo Mondi írta: > Hi Kieran > > On Mon, Mar 30, 2026 at 12:40:24PM +0100, Kieran Bingham wrote: >> Allow the camera properties to report what pipeline handler is managing >> the camera device. >> > > As you pointed out, the same platform could be supported by different > pipeline handlers, so I think this actually makes sense. > > However I wonder how an application is supposed to use this property, > this seems more like something useful during > development/experimentation > >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > But overall I don't see any drawback in adding such property, so Do the pipeline handler names have to become stable now? > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > >> --- >> src/libcamera/property_ids_core.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml >> index 834454a4e087..524cc48a08c7 100644 >> --- a/src/libcamera/property_ids_core.yaml >> +++ b/src/libcamera/property_ids_core.yaml >> @@ -701,4 +701,9 @@ controls: >> >> Different cameras may report identical devices. >> >> + - PipelineHandler: >> + type: string >> + description: | >> + The name of the pipeline handler that manages this camera device. >> + >> ... >> >> -- >> 2.52.0 >>
Quoting Barnabás Pőcze (2026-04-02 11:08:32) > 2026. 04. 02. 12:06 keltezéssel, Jacopo Mondi írta: > > Hi Kieran > > > > On Mon, Mar 30, 2026 at 12:40:24PM +0100, Kieran Bingham wrote: > >> Allow the camera properties to report what pipeline handler is managing > >> the camera device. > >> > > > > As you pointed out, the same platform could be supported by different > > pipeline handlers, so I think this actually makes sense. > > > > However I wonder how an application is supposed to use this property, > > this seems more like something useful during > > development/experimentation Camshark lists it as a property automatically and makes it really easy for me to know what pipeline handler I'm running. It's just a property. Applications don't have to make any use of it, except optionally tell the user if it's in their interests. > >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > But overall I don't see any drawback in adding such property, so > > Do the pipeline handler names have to become stable now? No, I don't think so. This isn't something which should be used to 'switch' on. It's just a property for information. -- Kieran > > > > > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > > >> --- > >> src/libcamera/property_ids_core.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml > >> index 834454a4e087..524cc48a08c7 100644 > >> --- a/src/libcamera/property_ids_core.yaml > >> +++ b/src/libcamera/property_ids_core.yaml > >> @@ -701,4 +701,9 @@ controls: > >> > >> Different cameras may report identical devices. > >> > >> + - PipelineHandler: > >> + type: string > >> + description: | > >> + The name of the pipeline handler that manages this camera device. > >> + > >> ... > >> > >> -- > >> 2.52.0 > >> >
Quoting Laurent Pinchart (2026-04-02 12:35:30) > On Thu, Apr 02, 2026 at 12:25:12PM +0100, Kieran Bingham wrote: > > Quoting Barnabás Pőcze (2026-04-02 11:08:32) > > > 2026. 04. 02. 12:06 keltezéssel, Jacopo Mondi írta: > > > > Hi Kieran > > > > > > > > On Mon, Mar 30, 2026 at 12:40:24PM +0100, Kieran Bingham wrote: > > > >> Allow the camera properties to report what pipeline handler is managing > > > >> the camera device. > > > > > > > > As you pointed out, the same platform could be supported by different > > > > pipeline handlers, so I think this actually makes sense. > > > > > > > > However I wonder how an application is supposed to use this property, > > > > this seems more like something useful during > > > > development/experimentation > > > > Camshark lists it as a property automatically and makes it really easy > > for me to know what pipeline handler I'm running. > > > > It's just a property. Applications don't have to make any use of it, > > except optionally tell the user if it's in their interests. > > > > > >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > > > > But overall I don't see any drawback in adding such property, so > > > > > > Do the pipeline handler names have to become stable now? > > > > No, I don't think so. This isn't something which should be used to > > 'switch' on. It's just a property for information. > > I agree, I think this property is very useful, but mostly for > development, debugging and support. > > > > > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > > > > > > >> --- > > > >> src/libcamera/property_ids_core.yaml | 5 +++++ > > > >> 1 file changed, 5 insertions(+) > > > >> > > > >> diff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml > > > >> index 834454a4e087..524cc48a08c7 100644 > > > >> --- a/src/libcamera/property_ids_core.yaml > > > >> +++ b/src/libcamera/property_ids_core.yaml > > > >> @@ -701,4 +701,9 @@ controls: > > > >> > > > >> Different cameras may report identical devices. > > > >> > > > >> + - PipelineHandler: > > > >> + type: string > > > >> + description: | > > > >> + The name of the pipeline handler that manages this camera device. > > The address the concern that the pipeline handler name isn't stable, I'd > mention it here. > > The name of the pipeline handler that manages this camera device. > > This property is meant to help development, debugging and support. The > pipeline handler name is not guaranteed to be stable across libcamera > releases. > > or something similar. With that, I'm fine adding that! > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Thanks all. -- Kieran > > > >> + > > > >> ... > > > >> > > -- > Regards, > > Laurent Pinchart
diff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml index 834454a4e087..524cc48a08c7 100644 --- a/src/libcamera/property_ids_core.yaml +++ b/src/libcamera/property_ids_core.yaml @@ -701,4 +701,9 @@ controls: Different cameras may report identical devices. + - PipelineHandler: + type: string + description: | + The name of the pipeline handler that manages this camera device. + ...
Allow the camera properties to report what pipeline handler is managing the camera device. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/libcamera/property_ids_core.yaml | 5 +++++ 1 file changed, 5 insertions(+)