[v2,5/7] meson: Use dependency object when checking for headers
diff mbox series

Message ID 20260323082000.1324115-6-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • meson: Add `softisp-gpu` option
Related show

Commit Message

Barnabás Pőcze March 23, 2026, 8:19 a.m. UTC
A dependency might very well have custom include directories,
so use it when checking for the header file.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bryan O'Donoghue March 24, 2026, 3:51 p.m. UTC | #1
On 23/03/2026 08:19, Barnabás Pőcze wrote:
> A dependency might very well have custom include directories,
> so use it when checking for the header file.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   src/libcamera/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 06ed34101..72b7bf02d 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -70,9 +70,9 @@ libcamera_deps = []
>   libatomic = cc.find_library('atomic', required : false)
>   libthreads = dependency('threads')
> 
> -mesa_works = cc.check_header('EGL/egl.h', required: false)
>   libegl = dependency('egl', required : false)
>   libglesv2 = dependency('glesv2', required : false)
> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)
> 
>   subdir('base')
>   subdir('converter')
> --
> 2.53.0
> 
Reviewed-by: Bryan O'Donoghue <bod.linux@nxsw.ie>

Patch
diff mbox series

diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index 06ed34101..72b7bf02d 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -70,9 +70,9 @@  libcamera_deps = []
 libatomic = cc.find_library('atomic', required : false)
 libthreads = dependency('threads')
 
-mesa_works = cc.check_header('EGL/egl.h', required: false)
 libegl = dependency('egl', required : false)
 libglesv2 = dependency('glesv2', required : false)
+mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)
 
 subdir('base')
 subdir('converter')