[v2,1/7] meson: Drop unnecessary egl, gles feature defines
diff mbox series

Message ID 20260323082000.1324115-2-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • meson: Add `softisp-gpu` option
Related show

Commit Message

Barnabás Pőcze March 23, 2026, 8:19 a.m. UTC 
`HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/meson.build | 8 --------
 1 file changed, 8 deletions(-)

Comments

Bryan O'Donoghue March 24, 2026, 3:49 p.m. UTC | #1 
On 23/03/2026 08:19, Barnabás Pőcze wrote:
> `HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   src/libcamera/meson.build | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index d15943586..c6c109a30 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -74,14 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)
>   libegl = dependency('egl', required : false)
>   libglesv2 = dependency('glesv2', required : false)
> 
> -if libegl.found()
> -    config_h.set('HAVE_LIBEGL', 1)
> -endif
> -
> -if libglesv2.found()
> -    config_h.set('HAVE_GLESV2', 1)
> -endif
> -
>   if mesa_works
>       libcamera_internal_sources += files([
>           'egl.cpp',
> --
> 2.53.0
> 

Reviewed-by: Bryan O'Donoghue <bod.linux@nxsw.ie>

Patch
diff mbox series 

diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index d15943586..c6c109a30 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -74,14 +74,6 @@  mesa_works = cc.check_header('EGL/egl.h', required: false)
 libegl = dependency('egl', required : false)
 libglesv2 = dependency('glesv2', required : false)
 
-if libegl.found()
-    config_h.set('HAVE_LIBEGL', 1)
-endif
-
-if libglesv2.found()
-    config_h.set('HAVE_GLESV2', 1)
-endif
-
 if mesa_works
     libcamera_internal_sources += files([
         'egl.cpp',