| Message ID | 20251024085130.995967-30-stefan.klug@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Stefan Klug (2025-10-24 17:50:53) > With the pipeline rework, it is a valid condition to obtain an > uninitialized frame context. Explain that in the comment and reduce the > log level. > > The same applies to the "already initialized" case. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/ipa/libipa/fc_queue.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h > index 812022c496ed..75e0072a6eb4 100644 > --- a/src/ipa/libipa/fc_queue.h > +++ b/src/ipa/libipa/fc_queue.h > @@ -64,7 +64,7 @@ public: > * an error condition ? > */ > if (frame != 0 && frame <= frameContext.frame_) > - LOG(FCQueue, Warning) > + LOG(FCQueue, Debug) > << "Frame " << frame << " already initialised"; > else > init(fc, frame); > @@ -112,12 +112,12 @@ public: > * The frame context has been retrieved before it was > * initialised through the initialise() call. This indicates an > * algorithm attempted to access a Frame context before it was > - * queued to the IPA. Controls applied for this request may be > - * left unhandled. > - * > - * \todo Set an error flag for per-frame control errors. > + * queued to the IPA. This can happen when a frame was dropped > + * in the kernel. Then one frame will not be queued for the > + * requests to catch up, but the pipeline will still call > + * prepare on that frame. > */ > - LOG(FCQueue, Warning) > + LOG(FCQueue, Debug) > << "Obtained an uninitialised FrameContext for " << frame; > > init(fc, frame); > -- > 2.48.1 >
diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h index 812022c496ed..75e0072a6eb4 100644 --- a/src/ipa/libipa/fc_queue.h +++ b/src/ipa/libipa/fc_queue.h @@ -64,7 +64,7 @@ public: * an error condition ? */ if (frame != 0 && frame <= frameContext.frame_) - LOG(FCQueue, Warning) + LOG(FCQueue, Debug) << "Frame " << frame << " already initialised"; else init(fc, frame); @@ -112,12 +112,12 @@ public: * The frame context has been retrieved before it was * initialised through the initialise() call. This indicates an * algorithm attempted to access a Frame context before it was - * queued to the IPA. Controls applied for this request may be - * left unhandled. - * - * \todo Set an error flag for per-frame control errors. + * queued to the IPA. This can happen when a frame was dropped + * in the kernel. Then one frame will not be queued for the + * requests to catch up, but the pipeline will still call + * prepare on that frame. */ - LOG(FCQueue, Warning) + LOG(FCQueue, Debug) << "Obtained an uninitialised FrameContext for " << frame; init(fc, frame);
With the pipeline rework, it is a valid condition to obtain an uninitialized frame context. Explain that in the comment and reduce the log level. The same applies to the "already initialized" case. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- src/ipa/libipa/fc_queue.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)