[v1,05/35] libcamera: delayed_controls: Add maxDelay() function
diff mbox series

Message ID 20251024085130.995967-6-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • rkisp1: pipeline rework for PFC
Related show

Commit Message

Stefan Klug Oct. 24, 2025, 8:50 a.m. UTC
Add a maxDelay() function to be able to query the maximum delay of
the sensor.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

---
---
 include/libcamera/internal/delayed_controls.h | 2 ++
 src/libcamera/delayed_controls.cpp            | 7 +++++++
 2 files changed, 9 insertions(+)

Comments

Paul Elder Jan. 22, 2026, 9:15 a.m. UTC | #1
Quoting Stefan Klug (2025-10-24 17:50:29)
> Add a maxDelay() function to be able to query the maximum delay of
> the sensor.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> 
> ---

Extra line :)

Otherwise,

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  include/libcamera/internal/delayed_controls.h | 2 ++
>  src/libcamera/delayed_controls.cpp            | 7 +++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h
> index c650e672d964..3182ebddd1fa 100644
> --- a/include/libcamera/internal/delayed_controls.h
> +++ b/include/libcamera/internal/delayed_controls.h
> @@ -35,6 +35,8 @@ public:
>         bool push(uint32_t sequence, const ControlList &controls);
>         ControlList get(uint32_t sequence);
>  
> +       uint32_t maxDelay() const { return maxDelay_; }
> +
>         void applyControls(uint32_t sequence);
>  
>  private:
> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
> index 67213fe87d53..35a624525b80 100644
> --- a/src/libcamera/delayed_controls.cpp
> +++ b/src/libcamera/delayed_controls.cpp
> @@ -259,6 +259,13 @@ ControlList DelayedControls::get(uint32_t sequence)
>         return out;
>  }
>  
> +/**
> + * \fn DelayedControls::maxDelay()
> + * \brief Get the maximum delay of the sensor
> + *
> + * \return The maximum delay of the sensor
> + */
> +
>  /**
>   * \brief Inform DelayedControls of the start of a new frame
>   * \param[in] sequence Sequence number of the frame that started
> -- 
> 2.48.1
>

Patch
diff mbox series

diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h
index c650e672d964..3182ebddd1fa 100644
--- a/include/libcamera/internal/delayed_controls.h
+++ b/include/libcamera/internal/delayed_controls.h
@@ -35,6 +35,8 @@  public:
 	bool push(uint32_t sequence, const ControlList &controls);
 	ControlList get(uint32_t sequence);
 
+	uint32_t maxDelay() const { return maxDelay_; }
+
 	void applyControls(uint32_t sequence);
 
 private:
diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
index 67213fe87d53..35a624525b80 100644
--- a/src/libcamera/delayed_controls.cpp
+++ b/src/libcamera/delayed_controls.cpp
@@ -259,6 +259,13 @@  ControlList DelayedControls::get(uint32_t sequence)
 	return out;
 }
 
+/**
+ * \fn DelayedControls::maxDelay()
+ * \brief Get the maximum delay of the sensor
+ *
+ * \return The maximum delay of the sensor
+ */
+
 /**
  * \brief Inform DelayedControls of the start of a new frame
  * \param[in] sequence Sequence number of the frame that started