[v1,03/35] libcamera: delayed_controls: Increase log level for dummy pushes
diff mbox series

Message ID 20251024085130.995967-4-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • rkisp1: pipeline rework for PFC
Related show

Commit Message

Stefan Klug Oct. 24, 2025, 8:50 a.m. UTC 
When an automatic no-op is queued a debug message is printed. Change the
debug level to warning, because that situation is actually an indication
of something going seriously out of sync.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/libcamera/delayed_controls.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Elder Jan. 22, 2026, 9:14 a.m. UTC | #1 
Quoting Stefan Klug (2025-10-24 17:50:27)
> When an automatic no-op is queued a debug message is printed. Change the
> debug level to warning, because that situation is actually an indication
> of something going seriously out of sync.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/delayed_controls.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
> index e5bdc374fd0e..044c6c7325e7 100644
> --- a/src/libcamera/delayed_controls.cpp
> +++ b/src/libcamera/delayed_controls.cpp
> @@ -313,7 +313,7 @@ void DelayedControls::applyControls(uint32_t sequence)
>         writeCount_ = sequence + 1;
>  
>         while (writeCount_ > queueCount_) {
> -               LOG(DelayedControls, Debug)
> +               LOG(DelayedControls, Warning)
>                         << "Queue is empty, auto queue no-op.";
>                 push(queueCount_, {});
>         }
> -- 
> 2.48.1
>

Patch
diff mbox series 

diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
index e5bdc374fd0e..044c6c7325e7 100644
--- a/src/libcamera/delayed_controls.cpp
+++ b/src/libcamera/delayed_controls.cpp
@@ -313,7 +313,7 @@  void DelayedControls::applyControls(uint32_t sequence)
 	writeCount_ = sequence + 1;
 
 	while (writeCount_ > queueCount_) {
-		LOG(DelayedControls, Debug)
+		LOG(DelayedControls, Warning)
 			<< "Queue is empty, auto queue no-op.";
 		push(queueCount_, {});
 	}