[0/3] Add vd56g3 support for rpi and libipa
mbox series

Message ID 20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com
Headers show
Series
  • Add vd56g3 support for rpi and libipa
Related show

Message

Benjamin Mugnier June 20, 2025, 1:49 p.m. UTC 
Following our discussion with Kieran and Naushir at the libcamera
workshop, here is the vd56g3 support for libcamera.

This series has been developed originally on the Raspberry Pi libcamera
fork and tested on rpi4 and rpi5. Then rebased on mainline and tested
again on rpi4 and rpi5 with the mainline rp1-cfe driver.

The libipa part has not been tested yet, but changes are rather trivial.
If you see any issues with that, please don't hesitate to remove the
patch from the series.

To: libcamera-devel@lists.libcamera.org
CC: Naushir Patuck <naush@raspberrypi.com>
CC: Kieran Bingham <kieran.bingham@ideasonboard.com>
CC: Sylvain Petinot <sylvain.petinot@foss.st.com>
CC: Cyril Liotard <cyril.liotard@st.com>
CC: Jean Poire <jean.poire@st.com>

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
Benjamin Mugnier (3):
      libcamera: camera_sensor_properties: Add vd56g3 camera sensor
      ipa: rpi: Add vd56g3 support for rpi
      libcamera: libipa: Add vd56g3 support for libipa

 src/ipa/libipa/camera_sensor_helper.cpp           |   12 +
 src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp      |   54 +
 src/ipa/rpi/cam_helper/meson.build                |    1 +
 src/ipa/rpi/pisp/data/meson.build                 |    2 +
 src/ipa/rpi/pisp/data/vd56g3.json                 | 1293 +++++++++++++++++++++
 src/ipa/rpi/pisp/data/vd56g3_mono.json            | 1155 ++++++++++++++++++
 src/ipa/rpi/vc4/data/meson.build                  |    2 +
 src/ipa/rpi/vc4/data/vd56g3.json                  |  417 +++++++
 src/ipa/rpi/vc4/data/vd56g3_mono.json             |  290 +++++
 src/libcamera/sensor/camera_sensor_properties.cpp |   21 +
 10 files changed, 3247 insertions(+)
---
base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316
change-id: 20250620-vd56g3_support-029e40405468

Best regards,

Comments

Benjamin Mugnier July 24, 2025, 9:08 a.m. UTC | #1 
Hi everyone,

On 6/20/25 15:49, Benjamin Mugnier wrote:
> Following our discussion with Kieran and Naushir at the libcamera
> workshop, here is the vd56g3 support for libcamera.
> 
> This series has been developed originally on the Raspberry Pi libcamera
> fork and tested on rpi4 and rpi5. Then rebased on mainline and tested
> again on rpi4 and rpi5 with the mainline rp1-cfe driver.
> 
> The libipa part has not been tested yet, but changes are rather trivial.
> If you see any issues with that, please don't hesitate to remove the
> patch from the series.
> 
> To: libcamera-devel@lists.libcamera.org
> CC: Naushir Patuck <naush@raspberrypi.com>
> CC: Kieran Bingham <kieran.bingham@ideasonboard.com>
> CC: Sylvain Petinot <sylvain.petinot@foss.st.com>
> CC: Cyril Liotard <cyril.liotard@st.com>
> CC: Jean Poire <jean.poire@st.com>
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>

Is everything okay with this patch set ?

> ---
> Benjamin Mugnier (3):
>       libcamera: camera_sensor_properties: Add vd56g3 camera sensor
>       ipa: rpi: Add vd56g3 support for rpi
>       libcamera: libipa: Add vd56g3 support for libipa
> 
>  src/ipa/libipa/camera_sensor_helper.cpp           |   12 +
>  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp      |   54 +
>  src/ipa/rpi/cam_helper/meson.build                |    1 +
>  src/ipa/rpi/pisp/data/meson.build                 |    2 +
>  src/ipa/rpi/pisp/data/vd56g3.json                 | 1293 +++++++++++++++++++++
>  src/ipa/rpi/pisp/data/vd56g3_mono.json            | 1155 ++++++++++++++++++
>  src/ipa/rpi/vc4/data/meson.build                  |    2 +
>  src/ipa/rpi/vc4/data/vd56g3.json                  |  417 +++++++
>  src/ipa/rpi/vc4/data/vd56g3_mono.json             |  290 +++++
>  src/libcamera/sensor/camera_sensor_properties.cpp |   21 +
>  10 files changed, 3247 insertions(+)
> ---
> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316
> change-id: 20250620-vd56g3_support-029e40405468
> 
> Best regards,
Naushir Patuck July 24, 2025, 9:22 a.m. UTC | #2 
Hi Benjamin,

On Thu, 24 Jul 2025 at 10:09, Benjamin Mugnier
<benjamin.mugnier@foss.st.com> wrote:
>
> Hi everyone,
>
> On 6/20/25 15:49, Benjamin Mugnier wrote:
> > Following our discussion with Kieran and Naushir at the libcamera
> > workshop, here is the vd56g3 support for libcamera.
> >
> > This series has been developed originally on the Raspberry Pi libcamera
> > fork and tested on rpi4 and rpi5. Then rebased on mainline and tested
> > again on rpi4 and rpi5 with the mainline rp1-cfe driver.
> >
> > The libipa part has not been tested yet, but changes are rather trivial.
> > If you see any issues with that, please don't hesitate to remove the
> > patch from the series.
> >
> > To: libcamera-devel@lists.libcamera.org
> > CC: Naushir Patuck <naush@raspberrypi.com>
> > CC: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > CC: Sylvain Petinot <sylvain.petinot@foss.st.com>
> > CC: Cyril Liotard <cyril.liotard@st.com>
> > CC: Jean Poire <jean.poire@st.com>
> >
> > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>
> Is everything okay with this patch set ?

Sorry - this slipped off my radar.  I'll add some tags today!

Naush


>
> > ---
> > Benjamin Mugnier (3):
> >       libcamera: camera_sensor_properties: Add vd56g3 camera sensor
> >       ipa: rpi: Add vd56g3 support for rpi
> >       libcamera: libipa: Add vd56g3 support for libipa
> >
> >  src/ipa/libipa/camera_sensor_helper.cpp           |   12 +
> >  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp      |   54 +
> >  src/ipa/rpi/cam_helper/meson.build                |    1 +
> >  src/ipa/rpi/pisp/data/meson.build                 |    2 +
> >  src/ipa/rpi/pisp/data/vd56g3.json                 | 1293 +++++++++++++++++++++
> >  src/ipa/rpi/pisp/data/vd56g3_mono.json            | 1155 ++++++++++++++++++
> >  src/ipa/rpi/vc4/data/meson.build                  |    2 +
> >  src/ipa/rpi/vc4/data/vd56g3.json                  |  417 +++++++
> >  src/ipa/rpi/vc4/data/vd56g3_mono.json             |  290 +++++
> >  src/libcamera/sensor/camera_sensor_properties.cpp |   21 +
> >  10 files changed, 3247 insertions(+)
> > ---
> > base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316
> > change-id: 20250620-vd56g3_support-029e40405468
> >
> > Best regards,
>
> --
> Regards,
> Benjamin
Laurent Pinchart July 24, 2025, 10:24 a.m. UTC | #3 
Hi Benjamin,

On Fri, Jun 20, 2025 at 03:49:15PM +0200, Benjamin Mugnier wrote:
> Following our discussion with Kieran and Naushir at the libcamera
> workshop, here is the vd56g3 support for libcamera.
> 
> This series has been developed originally on the Raspberry Pi libcamera
> fork and tested on rpi4 and rpi5. Then rebased on mainline and tested
> again on rpi4 and rpi5 with the mainline rp1-cfe driver.
> 
> The libipa part has not been tested yet, but changes are rather trivial.
> If you see any issues with that, please don't hesitate to remove the
> patch from the series.

The series looks good overall. There are a few small review comments,
could you send a v2 ? I think we can then merge it right away.

> To: libcamera-devel@lists.libcamera.org
> CC: Naushir Patuck <naush@raspberrypi.com>
> CC: Kieran Bingham <kieran.bingham@ideasonboard.com>
> CC: Sylvain Petinot <sylvain.petinot@foss.st.com>
> CC: Cyril Liotard <cyril.liotard@st.com>
> CC: Jean Poire <jean.poire@st.com>
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> Benjamin Mugnier (3):
>       libcamera: camera_sensor_properties: Add vd56g3 camera sensor
>       ipa: rpi: Add vd56g3 support for rpi
>       libcamera: libipa: Add vd56g3 support for libipa
> 
>  src/ipa/libipa/camera_sensor_helper.cpp           |   12 +
>  src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp      |   54 +
>  src/ipa/rpi/cam_helper/meson.build                |    1 +
>  src/ipa/rpi/pisp/data/meson.build                 |    2 +
>  src/ipa/rpi/pisp/data/vd56g3.json                 | 1293 +++++++++++++++++++++
>  src/ipa/rpi/pisp/data/vd56g3_mono.json            | 1155 ++++++++++++++++++
>  src/ipa/rpi/vc4/data/meson.build                  |    2 +
>  src/ipa/rpi/vc4/data/vd56g3.json                  |  417 +++++++
>  src/ipa/rpi/vc4/data/vd56g3_mono.json             |  290 +++++
>  src/libcamera/sensor/camera_sensor_properties.cpp |   21 +
>  10 files changed, 3247 insertions(+)
> ---
> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316
> change-id: 20250620-vd56g3_support-029e40405468