[v4,0/2] pipeline: imx8-isi: Add multicamera support
mbox series

Message ID 20250701085818.2447600-1-antoine.bouyer@nxp.com
Headers show
Series
  • pipeline: imx8-isi: Add multicamera support
Related show

Message

Antoine Bouyer July 1, 2025, 8:58 a.m. UTC
This is 4th patchset for adding support of multicamera into imx8-isi
pipeline handler. Compared to v3, it fixes rebase error because of one of
my previous imx8-isi patch:
  d3f3b95b64d2 ("pipeline: imx8-isi: Dynamically compute crossbar subdevice's first source.")

Really sorry for that. I should have fixed it in v2 already ! :(

Best regards
Antoine

Antoine Bouyer (2):
  pipeline: imx8-isi: Add constexpr for maximum pipeline and resize if
    needed
  pipeline: imx8-isi: Add multicamera support

 src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 119 ++++++++++++-------
 1 file changed, 79 insertions(+), 40 deletions(-)

Comments

Kieran Bingham July 18, 2025, 1:26 p.m. UTC | #1
Quoting Antoine Bouyer (2025-07-01 09:58:15)
> This is 4th patchset for adding support of multicamera into imx8-isi
> pipeline handler. Compared to v3, it fixes rebase error because of one of
> my previous imx8-isi patch:
>   d3f3b95b64d2 ("pipeline: imx8-isi: Dynamically compute crossbar subdevice's first source.")
> 
> Really sorry for that. I should have fixed it in v2 already ! :(
> 

Where are we with this series ? is it ready to merge?

I expect NXP have the best resources to test the ISI pipeline handler.

Has this been tested on both the i.MX8MP and the i.MX95 or other
platforms?

--
Kieran

> Best regards
> Antoine
> 
> Antoine Bouyer (2):
>   pipeline: imx8-isi: Add constexpr for maximum pipeline and resize if
>     needed
>   pipeline: imx8-isi: Add multicamera support
> 
>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 119 ++++++++++++-------
>  1 file changed, 79 insertions(+), 40 deletions(-)
> 
> -- 
> 2.34.1
>
Antoine Bouyer July 18, 2025, 3:53 p.m. UTC | #2
On 7/18/25 3:26 PM, Kieran Bingham wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> 
> 
> Quoting Antoine Bouyer (2025-07-01 09:58:15)
>> This is 4th patchset for adding support of multicamera into imx8-isi
>> pipeline handler. Compared to v3, it fixes rebase error because of one of
>> my previous imx8-isi patch:
>>    d3f3b95b64d2 ("pipeline: imx8-isi: Dynamically compute crossbar subdevice's first source.")
>>
>> Really sorry for that. I should have fixed it in v2 already ! :(
>>
> 
> Where are we with this series ? is it ready to merge?
> 
> I expect NXP have the best resources to test the ISI pipeline handler.
> 
> Has this been tested on both the i.MX8MP and the i.MX95 or other
> platforms?

Hi Kieran,

Yes, I tested it on iMX8MP. My iMX95 evk doesn't support multiple smart 
sensors. I also tested it on iMX8QM and iMX8QXP which do support 
multiple cameras (ov5640).

Best regards
Antoine

> 
> --
> Kieran
> 
>> Best regards
>> Antoine
>>
>> Antoine Bouyer (2):
>>    pipeline: imx8-isi: Add constexpr for maximum pipeline and resize if
>>      needed
>>    pipeline: imx8-isi: Add multicamera support
>>
>>   src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 119 ++++++++++++-------
>>   1 file changed, 79 insertions(+), 40 deletions(-)
>>
>> --
>> 2.34.1
>>
Kieran Bingham July 21, 2025, 4:22 p.m. UTC | #3
Quoting Antoine Bouyer (2025-07-18 16:53:14)
> On 7/18/25 3:26 PM, Kieran Bingham wrote:
> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> > 
> > 
> > Quoting Antoine Bouyer (2025-07-01 09:58:15)
> >> This is 4th patchset for adding support of multicamera into imx8-isi
> >> pipeline handler. Compared to v3, it fixes rebase error because of one of
> >> my previous imx8-isi patch:
> >>    d3f3b95b64d2 ("pipeline: imx8-isi: Dynamically compute crossbar subdevice's first source.")
> >>
> >> Really sorry for that. I should have fixed it in v2 already ! :(
> >>
> > 
> > Where are we with this series ? is it ready to merge?
> > 
> > I expect NXP have the best resources to test the ISI pipeline handler.
> > 
> > Has this been tested on both the i.MX8MP and the i.MX95 or other
> > platforms?
> 
> Hi Kieran,
> 
> Yes, I tested it on iMX8MP. My iMX95 evk doesn't support multiple smart 
> sensors. I also tested it on iMX8QM and iMX8QXP which do support 
> multiple cameras (ov5640).

It feels like quite an invasive change to the ISI pipeline handler
though. Perhaps we really need to have either some automated testing on
real i.MX8MP devices, or maybe I should have pushed back and asked for a
separate Tested-by: tag from another NXP/ISI user ... still - hopefully
this won't break things for anyone else ;-)

Anyway, as you're @NXP, and therefore pretty close to being considerable
as a maintainer for the ISI pipeline handler - along with a review by
tag from Laurent....

I've merged this.

--
Kieran



> Best regards
> Antoine
> 
> > 
> > --
> > Kieran
> > 
> >> Best regards
> >> Antoine
> >>
> >> Antoine Bouyer (2):
> >>    pipeline: imx8-isi: Add constexpr for maximum pipeline and resize if
> >>      needed
> >>    pipeline: imx8-isi: Add multicamera support
> >>
> >>   src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 119 ++++++++++++-------
> >>   1 file changed, 79 insertions(+), 40 deletions(-)
> >>
> >> --
> >> 2.34.1
> >>
>