[2/2] libcamera: software_isp: Remove unused IPAActiveState fields
diff mbox series

Message ID 20241029112501.140252-2-stanislaw.gruszka@linux.intel.com
State Accepted
Commit 1a2be886c08aea0e97da9b44bda639b59a2cd036
Headers show
Series
  • [1/2] libcamera: software_isp: Initialize exposure+gain before agc calculations
Related show

Commit Message

Stanislaw Gruszka Oct. 29, 2024, 11:25 a.m. UTC
Now agc struct in IPAActiveState is not used any longer. If there
will be need to have this struct, this patch can be reverted.

Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
 src/ipa/simple/ipa_context.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Milan Zamazal Oct. 29, 2024, 3:03 p.m. UTC | #1
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> writes:

> Now agc struct in IPAActiveState is not used any longer. If there
> will be need to have this struct, this patch can be reverted.
>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/ipa/simple/ipa_context.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h
> index c510c436..2885a851 100644
> --- a/src/ipa/simple/ipa_context.h
> +++ b/src/ipa/simple/ipa_context.h
> @@ -39,11 +39,6 @@ struct IPAActiveState {
>  		double blue;
>  	} gains;
>  
> -	struct {
> -		int32_t exposure;
> -		double again;
> -	} agc;
> -
>  	static constexpr unsigned int kGammaLookupSize = 1024;
>  	struct {
>  		std::array<double, kGammaLookupSize> gammaTable;
Kieran Bingham Nov. 29, 2024, 10:08 p.m. UTC | #2
Quoting Stanislaw Gruszka (2024-10-29 11:25:01)
> Now agc struct in IPAActiveState is not used any longer. If there
> will be need to have this struct, this patch can be reverted.
> 
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  src/ipa/simple/ipa_context.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h
> index c510c436..2885a851 100644
> --- a/src/ipa/simple/ipa_context.h
> +++ b/src/ipa/simple/ipa_context.h
> @@ -39,11 +39,6 @@ struct IPAActiveState {
>                 double blue;
>         } gains;
>  
> -       struct {
> -               int32_t exposure;
> -               double again;
> -       } agc;
> -
>         static constexpr unsigned int kGammaLookupSize = 1024;
>         struct {
>                 std::array<double, kGammaLookupSize> gammaTable;
> -- 
> 2.43.0
>

Patch
diff mbox series

diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h
index c510c436..2885a851 100644
--- a/src/ipa/simple/ipa_context.h
+++ b/src/ipa/simple/ipa_context.h
@@ -39,11 +39,6 @@  struct IPAActiveState {
 		double blue;
 	} gains;
 
-	struct {
-		int32_t exposure;
-		double again;
-	} agc;
-
 	static constexpr unsigned int kGammaLookupSize = 1024;
 	struct {
 		std::array<double, kGammaLookupSize> gammaTable;