utils: tuning: readme: Improve names of dependency packages
diff mbox series

Message ID 20240318101331.3960778-1-paul.elder@ideasonboard.com
State Accepted
Headers show
Series
  • utils: tuning: readme: Improve names of dependency packages
Related show

Commit Message

Paul Elder March 18, 2024, 10:13 a.m. UTC
Change the names of python packages in the list of dependencies to the
exact names that should be used in the pip install command.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 utils/tuning/README.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Laurent Pinchart March 18, 2024, 10:47 a.m. UTC | #1
Hi Paul,

Thank you for the patch.

On Mon, Mar 18, 2024 at 07:13:31PM +0900, Paul Elder wrote:
> Change the names of python packages in the list of dependencies to the
> exact names that should be used in the pip install command.

Sounds like a good idea.

> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  utils/tuning/README.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/tuning/README.rst b/utils/tuning/README.rst
> index ce533b2c..ce3e03fc 100644
> --- a/utils/tuning/README.rst
> +++ b/utils/tuning/README.rst
> @@ -5,7 +5,7 @@
>  Dependencies
>  ------------
>  
> -- cv2
> +- opencv-python

With alphabetical order preserved,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I wonder if we should have a requirements.txt file ?

>  - numpy
> -- pyexiv2
> +- py3exiv2
>  - rawpy
Dan Scally March 18, 2024, 12:34 p.m. UTC | #2
Hello both

On 18/03/2024 10:47, Laurent Pinchart wrote:
> Hi Paul,
>
> Thank you for the patch.
>
> On Mon, Mar 18, 2024 at 07:13:31PM +0900, Paul Elder wrote:
>> Change the names of python packages in the list of dependencies to the
>> exact names that should be used in the pip install command.
> Sounds like a good idea.
>
>> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
>> ---
>>   utils/tuning/README.rst | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/utils/tuning/README.rst b/utils/tuning/README.rst
>> index ce533b2c..ce3e03fc 100644
>> --- a/utils/tuning/README.rst
>> +++ b/utils/tuning/README.rst
>> @@ -5,7 +5,7 @@
>>   Dependencies
>>   ------------
>>   
>> -- cv2
>> +- opencv-python
> With alphabetical order preserved,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I wonder if we should have a requirements.txt file ?


I was just coming to propose that too. But correcting the package names is still good:


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>
>>   - numpy
>> -- pyexiv2
>> +- py3exiv2
>>   - rawpy

Patch
diff mbox series

diff --git a/utils/tuning/README.rst b/utils/tuning/README.rst
index ce533b2c..ce3e03fc 100644
--- a/utils/tuning/README.rst
+++ b/utils/tuning/README.rst
@@ -5,7 +5,7 @@ 
 Dependencies
 ------------
 
-- cv2
+- opencv-python
 - numpy
-- pyexiv2
+- py3exiv2
 - rawpy