| Message ID | 20240121224052.1049989-3-neal@gompa.dev |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Neal, Thank you for the patch. On Sun, Jan 21, 2024 at 05:39:54PM -0500, Neal Gompa via libcamera-devel wrote: > The documentation is effectively the same, but we should be pointing > to the actively supported and used Qt version. > > Signed-off-by: Neal Gompa <neal@gompa.dev> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'll merge this quickly, without waiting for 1/3. > --- > src/libcamera/base/signal.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp > index a46386a0..02290ad7 100644 > --- a/src/libcamera/base/signal.cpp > +++ b/src/libcamera/base/signal.cpp > @@ -74,7 +74,7 @@ SignalBase::SlotList SignalBase::slots() > * > * Signals and slots are a language construct aimed at communication between > * objects through the observer pattern without the need for boilerplate code. > - * See http://doc.qt.io/qt-5/signalsandslots.html for more information. > + * See http://doc.qt.io/qt-6/signalsandslots.html for more information. > * > * Signals model events that can be observed from objects unrelated to the event > * source. Slots are functions that are called in response to a signal. Signals
On Sun, 21 Jan 2024 at 22:41, Neal Gompa <neal@gompa.dev> wrote: > > The documentation is effectively the same, but we should be pointing > to the actively supported and used Qt version. > > Signed-off-by: Neal Gompa <neal@gompa.dev> Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > --- > src/libcamera/base/signal.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp > index a46386a0..02290ad7 100644 > --- a/src/libcamera/base/signal.cpp > +++ b/src/libcamera/base/signal.cpp > @@ -74,7 +74,7 @@ SignalBase::SlotList SignalBase::slots() > * > * Signals and slots are a language construct aimed at communication between > * objects through the observer pattern without the need for boilerplate code. > - * See http://doc.qt.io/qt-5/signalsandslots.html for more information. > + * See http://doc.qt.io/qt-6/signalsandslots.html for more information. > * > * Signals model events that can be observed from objects unrelated to the event > * source. Slots are functions that are called in response to a signal. Signals > -- > 2.43.0 >
diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp index a46386a0..02290ad7 100644 --- a/src/libcamera/base/signal.cpp +++ b/src/libcamera/base/signal.cpp @@ -74,7 +74,7 @@ SignalBase::SlotList SignalBase::slots() * * Signals and slots are a language construct aimed at communication between * objects through the observer pattern without the need for boilerplate code. - * See http://doc.qt.io/qt-5/signalsandslots.html for more information. + * See http://doc.qt.io/qt-6/signalsandslots.html for more information. * * Signals model events that can be observed from objects unrelated to the event * source. Slots are functions that are called in response to a signal. Signals
The documentation is effectively the same, but we should be pointing to the actively supported and used Qt version. Signed-off-by: Neal Gompa <neal@gompa.dev> --- src/libcamera/base/signal.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)