| Message ID | 20220729084033.5435-1-jacopo@jmondi.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, On 7/29/22 14:10, Jacopo Mondi via libcamera-devel wrote: > Building on gcc8 on Debian 10 fails with > > asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this)); > ../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’ > is defined in header ‘<functional>’; did you forget to ‘#include > <functional>’? > > Fix that by including <functional> in awb.cpp. > > Fixes: c1597f989654 ("ipa: raspberrypi: Use YamlParser to replace dependency on boost") > Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/414 > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > > --- > v1->v2: > - Rebased on latest changes and addded tags > > One more review and I'll push. > --- > src/ipa/raspberrypi/controller/rpi/awb.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp > index a16e04a07ff8..2b88c3b0141b 100644 > --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp > +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp > @@ -6,6 +6,7 @@ > */ > > #include <assert.h> > +#include <functional> > > #include <libcamera/base/log.h> > > -- > 2.37.1 >
diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp index a16e04a07ff8..2b88c3b0141b 100644 --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp @@ -6,6 +6,7 @@ */ #include <assert.h> +#include <functional> #include <libcamera/base/log.h>
Building on gcc8 on Debian 10 fails with asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this)); ../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’ is defined in header ‘<functional>’; did you forget to ‘#include <functional>’? Fix that by including <functional> in awb.cpp. Fixes: c1597f989654 ("ipa: raspberrypi: Use YamlParser to replace dependency on boost") Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/414 Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- v1->v2: - Rebased on latest changes and addded tags One more review and I'll push. --- src/ipa/raspberrypi/controller/rpi/awb.cpp | 1 + 1 file changed, 1 insertion(+) -- 2.37.1