| Message ID | 20220525114107.3764033-1-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | 6f53f01409747369f4308acabdb4f44176a5e2c6 |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, Thank you for the patch. On Wed, May 25, 2022 at 12:41:07PM +0100, Naushir Patuck via libcamera-devel wrote: > Add an entry to the sensor properties for Sony IMX477. Currently > no test pattern modes are supported by the device driver. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Could you however also add support for the sensor to the CameraSensorHelper in src/ipa/libipa/ ? > --- > src/libcamera/camera_sensor_properties.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp > index 235edca190ce..e5f27f06eb1d 100644 > --- a/src/libcamera/camera_sensor_properties.cpp > +++ b/src/libcamera/camera_sensor_properties.cpp > @@ -98,6 +98,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > .unitCellSize = { 3450, 3450 }, > .testPatternModes = {}, > } }, > + { "imx477", { > + .unitCellSize = { 1550, 1550 }, > + .testPatternModes = {}, > + } }, > { "ov2740", { > .unitCellSize = { 1400, 1400 }, > .testPatternModes = {
Hi Naush, On Wed, May 25, 2022 at 12:41:07PM +0100, Naushir Patuck via libcamera-devel wrote: > Add an entry to the sensor properties for Sony IMX477. Currently > no test pattern modes are supported by the device driver. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/libcamera/camera_sensor_properties.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp > index 235edca190ce..e5f27f06eb1d 100644 > --- a/src/libcamera/camera_sensor_properties.cpp > +++ b/src/libcamera/camera_sensor_properties.cpp > @@ -98,6 +98,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > .unitCellSize = { 3450, 3450 }, > .testPatternModes = {}, > } }, > + { "imx477", { > + .unitCellSize = { 1550, 1550 }, > + .testPatternModes = {}, > + } }, > { "ov2740", { > .unitCellSize = { 1400, 1400 }, > .testPatternModes = { > -- > 2.34.1 >
diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index 235edca190ce..e5f27f06eb1d 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -98,6 +98,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .unitCellSize = { 3450, 3450 }, .testPatternModes = {}, } }, + { "imx477", { + .unitCellSize = { 1550, 1550 }, + .testPatternModes = {}, + } }, { "ov2740", { .unitCellSize = { 1400, 1400 }, .testPatternModes = {
Add an entry to the sensor properties for Sony IMX477. Currently no test pattern modes are supported by the device driver. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/camera_sensor_properties.cpp | 4 ++++ 1 file changed, 4 insertions(+)