| Message ID | 20220316222245.132315-2-djrscally@gmail.com |
|---|---|
| State | Accepted |
| Commit | 1b22c03284b21e3b92ad312f8fbfadc9e21752b3 |
| Headers | show |
| Series |
|
| Related | show |
Hi Dan, Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44) > Add camera sensor property entries for the OmniVision 2740 camera > sensor. > > Signed-off-by: Daniel Scally <djrscally@gmail.com> > --- > src/libcamera/camera_sensor_properties.cpp | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp > index 48305ac4..9bdfd417 100644 > --- a/src/libcamera/camera_sensor_properties.cpp > +++ b/src/libcamera/camera_sensor_properties.cpp > @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > { controls::draft::TestPatternModePn9, 4 }, > }, > } }, > + { "ov2740", { > + .unitCellSize = { 1400, 1400 }, https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf confirms this, > + .testPatternModes = { > + { controls::draft::TestPatternModeOff, 0 }, > + { controls::draft::TestPatternModeColorBars, 1}, and drivers/media/i2c/ov2740.c confirms this. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > + }, > + } }, > { "ov5647", { > .unitCellSize = { 1400, 1400 }, > .testPatternModes = {}, > -- > 2.25.1 >
On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote: > Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44) > > Add camera sensor property entries for the OmniVision 2740 camera > > sensor. > > > > Signed-off-by: Daniel Scally <djrscally@gmail.com> > > --- > > src/libcamera/camera_sensor_properties.cpp | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp > > index 48305ac4..9bdfd417 100644 > > --- a/src/libcamera/camera_sensor_properties.cpp > > +++ b/src/libcamera/camera_sensor_properties.cpp > > @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > > { controls::draft::TestPatternModePn9, 4 }, > > }, > > } }, > > + { "ov2740", { > > + .unitCellSize = { 1400, 1400 }, > > https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf > confirms this, > > > + .testPatternModes = { > > + { controls::draft::TestPatternModeOff, 0 }, > > + { controls::draft::TestPatternModeColorBars, 1}, > > and drivers/media/i2c/ov2740.c confirms this. Is this the standard colour bars pattern (as specified in the control documentation, referencing the MIPI CCS specification) ? > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > + }, > > + } }, > > { "ov5647", { > > .unitCellSize = { 1400, 1400 }, > > .testPatternModes = {},
Morning Laurent On 17/03/2022 07:57, Laurent Pinchart wrote: > On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote: >> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44) >>> Add camera sensor property entries for the OmniVision 2740 camera >>> sensor. >>> >>> Signed-off-by: Daniel Scally <djrscally@gmail.com> >>> --- >>> src/libcamera/camera_sensor_properties.cpp | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp >>> index 48305ac4..9bdfd417 100644 >>> --- a/src/libcamera/camera_sensor_properties.cpp >>> +++ b/src/libcamera/camera_sensor_properties.cpp >>> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen >>> { controls::draft::TestPatternModePn9, 4 }, >>> }, >>> } }, >>> + { "ov2740", { >>> + .unitCellSize = { 1400, 1400 }, >> https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf >> confirms this, >> >>> + .testPatternModes = { >>> + { controls::draft::TestPatternModeOff, 0 }, >>> + { controls::draft::TestPatternModeColorBars, 1}, >> and drivers/media/i2c/ov2740.c confirms this. > Is this the standard colour bars pattern (as specified in the control > documentation, referencing the MIPI CCS specification) ? This mode matches the specification in the control documentation yes (there are 3 other "color bar" test patterns in the driver that don't though). > >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> >>> + }, >>> + } }, >>> { "ov5647", { >>> .unitCellSize = { 1400, 1400 }, >>> .testPatternModes = {},
Hi Dan, On Thu, Mar 17, 2022 at 09:49:12AM +0000, Daniel Scally wrote: > On 17/03/2022 07:57, Laurent Pinchart wrote: > > On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote: > >> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44) > >>> Add camera sensor property entries for the OmniVision 2740 camera > >>> sensor. > >>> > >>> Signed-off-by: Daniel Scally <djrscally@gmail.com> > >>> --- > >>> src/libcamera/camera_sensor_properties.cpp | 7 +++++++ > >>> 1 file changed, 7 insertions(+) > >>> > >>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp > >>> index 48305ac4..9bdfd417 100644 > >>> --- a/src/libcamera/camera_sensor_properties.cpp > >>> +++ b/src/libcamera/camera_sensor_properties.cpp > >>> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > >>> { controls::draft::TestPatternModePn9, 4 }, > >>> }, > >>> } }, > >>> + { "ov2740", { > >>> + .unitCellSize = { 1400, 1400 }, > >> > >> https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf > >> confirms this, > >> > >>> + .testPatternModes = { > >>> + { controls::draft::TestPatternModeOff, 0 }, > >>> + { controls::draft::TestPatternModeColorBars, 1}, > >> and drivers/media/i2c/ov2740.c confirms this. > > > > Is this the standard colour bars pattern (as specified in the control > > documentation, referencing the MIPI CCS specification) ? > > This mode matches the specification in the control documentation yes > (there are 3 other "color bar" test patterns in the driver that don't > though). Thank you for the confirmation. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > >> > >>> + }, > >>> + } }, > >>> { "ov5647", { > >>> .unitCellSize = { 1400, 1400 }, > >>> .testPatternModes = {},
diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index 48305ac4..9bdfd417 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen { controls::draft::TestPatternModePn9, 4 }, }, } }, + { "ov2740", { + .unitCellSize = { 1400, 1400 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1}, + }, + } }, { "ov5647", { .unitCellSize = { 1400, 1400 }, .testPatternModes = {},
Add camera sensor property entries for the OmniVision 2740 camera sensor. Signed-off-by: Daniel Scally <djrscally@gmail.com> --- src/libcamera/camera_sensor_properties.cpp | 7 +++++++ 1 file changed, 7 insertions(+)