| Message ID | 20220110165524.72978-6-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Delegated to: | Jacopo Mondi |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, thank you for the patch. On Tue, Jan 11, 2022 at 1:54 AM Jacopo Mondi <jacopo@jmondi.org> wrote: > > When a request completes, a debug message is generated to help > identify the request and the number of streams if contains. > > The printed number of streams is however the number of output buffers > requested by the camera framework, not the number of streams generated > by libcamera. In facts, some output buffers are generated by > post-processing, and not directly from the camera. > > As the debug message prints the libcamera identifier for the Request, it > is more logical to print the number of streams generated by the camera > instead of the total number of streams. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > --- > src/android/camera_device.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > index 4e44bcfa0852..88cb4f943757 100644 > --- a/src/android/camera_device.cpp > +++ b/src/android/camera_device.cpp > @@ -1196,7 +1196,7 @@ void CameraDevice::requestComplete(Request *request) > notifyShutter(descriptor->frameNumber_, sensorTimestamp); > > LOG(HAL, Debug) << "Request " << request->cookie() << " completed with " > - << descriptor->buffers_.size() << " streams"; > + << descriptor->request_->buffers().size() << " streams"; > > /* > * Generate the metadata associated with the captured buffers. > -- > 2.34.1 >
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 4e44bcfa0852..88cb4f943757 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1196,7 +1196,7 @@ void CameraDevice::requestComplete(Request *request) notifyShutter(descriptor->frameNumber_, sensorTimestamp); LOG(HAL, Debug) << "Request " << request->cookie() << " completed with " - << descriptor->buffers_.size() << " streams"; + << descriptor->request_->buffers().size() << " streams"; /* * Generate the metadata associated with the captured buffers.
When a request completes, a debug message is generated to help identify the request and the number of streams if contains. The printed number of streams is however the number of output buffers requested by the camera framework, not the number of streams generated by libcamera. In facts, some output buffers are generated by post-processing, and not directly from the camera. As the debug message prints the libcamera identifier for the Request, it is more logical to print the number of streams generated by the camera instead of the total number of streams. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/android/camera_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)