| Message ID | 20211209202818.29950-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 8a480237f6442a87f14aed2137b72b4d21fcae4f |
| Headers | show |
| Series |
|
| Related | show |
Quoting Laurent Pinchart (2021-12-09 20:28:18) > The build/ and patches/ directories are listed in .gitignore as they're > commonly used respectively as the meson build directory (this is the > directory name used in README.rst) and as a local patches store (this > usage pattern isn't official though, and may need to be reconsidered if > not used anymore). As those two directories are supposed to be at the > root of the source tree, restrict the corresponding .gitignore patterns > to avoid matching other locations. > > While at it, sort the entries alphabetically, with the absolute path > entries separate from the entries that match any location within the > source tree. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Fine with me. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > .gitignore | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/.gitignore b/.gitignore > index d3d73615bac1..f6d1d68e4a7c 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,7 +1,8 @@ > # SPDX-License-Identifier: CC0-1.0 > > -__pycache__/ > -build/ > -patches/ > +/build/ > +/patches/ > + > *.patch > *.pyc > +__pycache__/ > > base-commit: f16acb275c85518c13e81ffa6503347abcc01dc5 > -- > Regards, > > Laurent Pinchart >
Hi Kieran, On Thu, Dec 09, 2021 at 10:28:18PM +0200, Laurent Pinchart wrote: > The build/ and patches/ directories are listed in .gitignore as they're > commonly used respectively as the meson build directory (this is the > directory name used in README.rst) and as a local patches store (this > usage pattern isn't official though, and may need to be reconsidered if > not used anymore). As those two directories are supposed to be at the > root of the source tree, restrict the corresponding .gitignore patterns > to avoid matching other locations. > > While at it, sort the entries alphabetically, with the absolute path > entries separate from the entries that match any location within the > source tree. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > .gitignore | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/.gitignore b/.gitignore > index d3d73615bac1..f6d1d68e4a7c 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,7 +1,8 @@ > # SPDX-License-Identifier: CC0-1.0 > > -__pycache__/ > -build/ > -patches/ > +/build/ > +/patches/ > + > *.patch > *.pyc > +__pycache__/ > > base-commit: f16acb275c85518c13e81ffa6503347abcc01dc5 > -- > Regards, > > Laurent Pinchart >
diff --git a/.gitignore b/.gitignore index d3d73615bac1..f6d1d68e4a7c 100644 --- a/.gitignore +++ b/.gitignore @@ -1,7 +1,8 @@ # SPDX-License-Identifier: CC0-1.0 -__pycache__/ -build/ -patches/ +/build/ +/patches/ + *.patch *.pyc +__pycache__/
The build/ and patches/ directories are listed in .gitignore as they're commonly used respectively as the meson build directory (this is the directory name used in README.rst) and as a local patches store (this usage pattern isn't official though, and may need to be reconsidered if not used anymore). As those two directories are supposed to be at the root of the source tree, restrict the corresponding .gitignore patterns to avoid matching other locations. While at it, sort the entries alphabetically, with the absolute path entries separate from the entries that match any location within the source tree. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .gitignore | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) base-commit: f16acb275c85518c13e81ffa6503347abcc01dc5