| Message ID | 20211111104958.312070-1-hanlinchen@chromium.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Han-Lin Chen (2021-11-11 10:49:56) > IPU3Event and IPU3Action use two fields for both libcamera controls and sensor > V4L2 controls. The patch extend one more field for lens V4L2 controls > for auto focus usage. > > Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org> To match the Sensor controls, this makes sense to me. We are considering making more direct/specific calls rather than going through the IPU3Event, but until that happens, I think this should get intgrated. Early integration will help align the requirements, and this patch itself isn't too controversial. I think separation of the control types makes this much clearer, and lens controls are clearly distinct from sensor controls ... so... Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > include/libcamera/ipa/ipu3.mojom | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom > index 16e3462e..cc0d822f 100644 > --- a/include/libcamera/ipa/ipu3.mojom > +++ b/include/libcamera/ipa/ipu3.mojom > @@ -24,12 +24,14 @@ struct IPU3Event { > uint32 bufferId; > libcamera.ControlList controls; > libcamera.ControlList sensorControls; > + libcamera.ControlList lensControls; > }; > > struct IPU3Action { > IPU3Operations op; > libcamera.ControlList controls; > libcamera.ControlList sensorControls; > + libcamera.ControlList lensControls; > }; > > struct IPAConfigInfo { > -- > 2.34.0.rc1.387.gb447b232ab-goog >
diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom index 16e3462e..cc0d822f 100644 --- a/include/libcamera/ipa/ipu3.mojom +++ b/include/libcamera/ipa/ipu3.mojom @@ -24,12 +24,14 @@ struct IPU3Event { uint32 bufferId; libcamera.ControlList controls; libcamera.ControlList sensorControls; + libcamera.ControlList lensControls; }; struct IPU3Action { IPU3Operations op; libcamera.ControlList controls; libcamera.ControlList sensorControls; + libcamera.ControlList lensControls; }; struct IPAConfigInfo {
IPU3Event and IPU3Action use two fields for both libcamera controls and sensor V4L2 controls. The patch extend one more field for lens V4L2 controls for auto focus usage. Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org> --- include/libcamera/ipa/ipu3.mojom | 2 ++ 1 file changed, 2 insertions(+)