| Message ID | 20210301150111.61791-2-jacopo@jmondi.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Mon, Mar 01, 2021 at 04:01:02PM +0100, Jacopo Mondi wrote: > The Android Camera3 HAL implementation requires platform > specific extensions, such as the selection of the memory backend > to use and additional constraints depending on the target device. > > Define a combo option to select which platform to target and > define the currently existing implementation as 'generic'. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > meson_options.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/meson_options.txt b/meson_options.txt > index 53f2675e99e2..d840543b01f5 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -5,6 +5,12 @@ option('android', > value : 'disabled', > description : 'Compile libcamera with Android Camera3 HAL interface') > > +option('android_platform', > + type : 'combo', > + choices : ['generic'], > + value : 'generic', > + description : 'Select the Android platform to compile for') > + > option('documentation', > type : 'feature', > description : 'Generate the project documentation')
Hi Jacopo, On Mon, Mar 01, 2021 at 04:01:02PM +0100, Jacopo Mondi wrote: > The Android Camera3 HAL implementation requires platform > specific extensions, such as the selection of the memory backend > to use and additional constraints depending on the target device. > > Define a combo option to select which platform to target and > define the currently existing implementation as 'generic'. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > meson_options.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/meson_options.txt b/meson_options.txt > index 53f2675e99e2..d840543b01f5 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -5,6 +5,12 @@ option('android', > value : 'disabled', > description : 'Compile libcamera with Android Camera3 HAL interface') > > +option('android_platform', > + type : 'combo', > + choices : ['generic'], > + value : 'generic', > + description : 'Select the Android platform to compile for') > + > option('documentation', > type : 'feature', > description : 'Generate the project documentation') > -- > 2.30.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/meson_options.txt b/meson_options.txt index 53f2675e99e2..d840543b01f5 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -5,6 +5,12 @@ option('android', value : 'disabled', description : 'Compile libcamera with Android Camera3 HAL interface') +option('android_platform', + type : 'combo', + choices : ['generic'], + value : 'generic', + description : 'Select the Android platform to compile for') + option('documentation', type : 'feature', description : 'Generate the project documentation')
The Android Camera3 HAL implementation requires platform specific extensions, such as the selection of the memory backend to use and additional constraints depending on the target device. Define a combo option to select which platform to target and define the currently existing implementation as 'generic'. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- meson_options.txt | 6 ++++++ 1 file changed, 6 insertions(+)