| Message ID | 20210202145114.62314-1-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Commit | 3e952cfb0f8ef3c6a6594420dccfcbf5f9a9624b |
| Headers | show |
| Series |
|
| Related | show |
On 02/02/2021 14:51, Jacopo Mondi wrote: > The function declaration fits on one line. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/cio2.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp > index bd5260d5b288..72e88067f55f 100644 > --- a/src/libcamera/pipeline/ipu3/cio2.cpp > +++ b/src/libcamera/pipeline/ipu3/cio2.cpp > @@ -195,8 +195,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat) > return 0; > } > > -StreamConfiguration > -CIO2Device::generateConfiguration(Size size) const > +StreamConfiguration CIO2Device::generateConfiguration(Size size) const > { > StreamConfiguration cfg; > >
Hi Jacopo, Thank you for the patch. On Tue, Feb 02, 2021 at 03:51:14PM +0100, Jacopo Mondi wrote: > The function declaration fits on one line. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/libcamera/pipeline/ipu3/cio2.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp > index bd5260d5b288..72e88067f55f 100644 > --- a/src/libcamera/pipeline/ipu3/cio2.cpp > +++ b/src/libcamera/pipeline/ipu3/cio2.cpp > @@ -195,8 +195,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat) > return 0; > } > > -StreamConfiguration > -CIO2Device::generateConfiguration(Size size) const > +StreamConfiguration CIO2Device::generateConfiguration(Size size) const Hmmmm... That's a complex change, I'm not sure I have the knowledge necessary to review this, but I'll still give it a go :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > { > StreamConfiguration cfg; >
diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp index bd5260d5b288..72e88067f55f 100644 --- a/src/libcamera/pipeline/ipu3/cio2.cpp +++ b/src/libcamera/pipeline/ipu3/cio2.cpp @@ -195,8 +195,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat) return 0; } -StreamConfiguration -CIO2Device::generateConfiguration(Size size) const +StreamConfiguration CIO2Device::generateConfiguration(Size size) const { StreamConfiguration cfg;
The function declaration fits on one line. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/pipeline/ipu3/cio2.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)