[libcamera-devel] libcamera: file_descriptor: Remove spurious 'is'

Message ID 20201006115640.10864-1-jacopo@jmondi.org
State Accepted
Commit 6193e9c25277c8fd16bb0475c640cc29104115de
Headers show
Series
  • [libcamera-devel] libcamera: file_descriptor: Remove spurious 'is'
Related show

Commit Message

Jacopo Mondi Oct. 6, 2020, 11:56 a.m. UTC
Remove a spurious 'is' is a comment block.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/file_descriptor.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.28.0

Comments

Umang Jain Oct. 6, 2020, 11:58 a.m. UTC | #1
Hi Jacopo,

Looks like you mail a/c recovered. :)

On 10/6/20 5:26 PM, Jacopo Mondi wrote:
> Remove a spurious 'is' is a comment block.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Umang Jain <email@uajain.com>
> ---
>   src/libcamera/file_descriptor.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/file_descriptor.cpp
> index 640e66e6d168..8b505ed3b6b2 100644
> --- a/src/libcamera/file_descriptor.cpp
> +++ b/src/libcamera/file_descriptor.cpp
> @@ -42,7 +42,7 @@ LOG_DEFINE_CATEGORY(FileDescriptor)
>    *   constructor.
>    *
>    * - The FileDescriptor(int &&) constructor takes over the numerical file
> - *   descriptor and wraps it in a Descriptor. The caller is shall not touch the
> + *   descriptor and wraps it in a Descriptor. The caller shall not touch the
>    *   original file descriptor once the function returns, and the value returned
>    *   by fd() will be identical to the value passed to the constructor.
>    *
> --
> 2.28.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Kieran Bingham Oct. 6, 2020, 7:47 p.m. UTC | #2
Hi Jacopo,

On 06/10/2020 12:56, Jacopo Mondi wrote:
> Remove a spurious 'is' is a comment block.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/file_descriptor.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/file_descriptor.cpp
> index 640e66e6d168..8b505ed3b6b2 100644
> --- a/src/libcamera/file_descriptor.cpp
> +++ b/src/libcamera/file_descriptor.cpp
> @@ -42,7 +42,7 @@ LOG_DEFINE_CATEGORY(FileDescriptor)
>   *   constructor.
>   *
>   * - The FileDescriptor(int &&) constructor takes over the numerical file
> - *   descriptor and wraps it in a Descriptor. The caller is shall not touch the
> + *   descriptor and wraps it in a Descriptor. The caller shall not touch the
>   *   original file descriptor once the function returns, and the value returned
>   *   by fd() will be identical to the value passed to the constructor.
>   *
> --
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>

Patch

diff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/file_descriptor.cpp
index 640e66e6d168..8b505ed3b6b2 100644
--- a/src/libcamera/file_descriptor.cpp
+++ b/src/libcamera/file_descriptor.cpp
@@ -42,7 +42,7 @@  LOG_DEFINE_CATEGORY(FileDescriptor)
  *   constructor.
  *
  * - The FileDescriptor(int &&) constructor takes over the numerical file
- *   descriptor and wraps it in a Descriptor. The caller is shall not touch the
+ *   descriptor and wraps it in a Descriptor. The caller shall not touch the
  *   original file descriptor once the function returns, and the value returned
  *   by fd() will be identical to the value passed to the constructor.
  *