[libcamera-devel,v7,0/5] v4l2_(sub)dev: improvements and tests
mbox series

Message ID 20190301154103.19588-1-jacopo@jmondi.org
Headers show
Series
  • v4l2_(sub)dev: improvements and tests
Related show

Message

Jacopo Mondi March 1, 2019, 3:40 p.m. UTC 
Hello,
  few minor changes to address Laurent's comments.

1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY,
   I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE
2) remove method reordering in v4l2_device cosmetic patch
3) use std::vector.empty() instead of (std::vector.size() == 0) in list
   formats test.

Hopefully this version might be pushed.

Thanks
   j

Jacopo Mondi (5):
  libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES
  test: v4l2_subdevice: Add ListFormat test
  libcamera: v4l2_subdevice: Cosmetic update
  libcamera: v4l2_device: Add support for META_CAPTURE devices
  libcamera: v4l2_device: Cosmetic update

 src/libcamera/geometry.cpp             |  34 ++++++++
 src/libcamera/include/geometry.h       |  12 +++
 src/libcamera/include/v4l2_device.h    |  26 +++++-
 src/libcamera/include/v4l2_subdevice.h |  11 ++-
 src/libcamera/v4l2_device.cpp          |  92 ++++++++++++++-------
 src/libcamera/v4l2_subdevice.cpp       | 107 ++++++++++++++++++++++---
 test/v4l2_subdevice/list_formats.cpp   |  81 +++++++++++++++++++
 test/v4l2_subdevice/meson.build        |   1 +
 8 files changed, 321 insertions(+), 43 deletions(-)
 create mode 100644 test/v4l2_subdevice/list_formats.cpp

--
2.20.1

Comments

Laurent Pinchart March 1, 2019, 6:01 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patches.

On Fri, Mar 01, 2019 at 04:40:58PM +0100, Jacopo Mondi wrote:
> Hello,
>   few minor changes to address Laurent's comments.
> 
> 1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY,
>    I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE
> 2) remove method reordering in v4l2_device cosmetic patch
> 3) use std::vector.empty() instead of (std::vector.size() == 0) in list
>    formats test.
> 
> Hopefully this version might be pushed.

For the wholes series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Jacopo Mondi (5):
>   libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES
>   test: v4l2_subdevice: Add ListFormat test
>   libcamera: v4l2_subdevice: Cosmetic update
>   libcamera: v4l2_device: Add support for META_CAPTURE devices
>   libcamera: v4l2_device: Cosmetic update
> 
>  src/libcamera/geometry.cpp             |  34 ++++++++
>  src/libcamera/include/geometry.h       |  12 +++
>  src/libcamera/include/v4l2_device.h    |  26 +++++-
>  src/libcamera/include/v4l2_subdevice.h |  11 ++-
>  src/libcamera/v4l2_device.cpp          |  92 ++++++++++++++-------
>  src/libcamera/v4l2_subdevice.cpp       | 107 ++++++++++++++++++++++---
>  test/v4l2_subdevice/list_formats.cpp   |  81 +++++++++++++++++++
>  test/v4l2_subdevice/meson.build        |   1 +
>  8 files changed, 321 insertions(+), 43 deletions(-)
>  create mode 100644 test/v4l2_subdevice/list_formats.cpp
Jacopo Mondi March 2, 2019, 5:33 p.m. UTC | #2 
Hi Laurent,

On Fri, Mar 01, 2019 at 08:01:28PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patches.
>
> On Fri, Mar 01, 2019 at 04:40:58PM +0100, Jacopo Mondi wrote:
> > Hello,
> >   few minor changes to address Laurent's comments.
> >
> > 1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY,
> >    I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE
> > 2) remove method reordering in v4l2_device cosmetic patch
> > 3) use std::vector.empty() instead of (std::vector.size() == 0) in list
> >    formats test.
> >
> > Hopefully this version might be pushed.
>
> For the wholes series,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, series now pushed to master

>
> > Jacopo Mondi (5):
> >   libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES
> >   test: v4l2_subdevice: Add ListFormat test
> >   libcamera: v4l2_subdevice: Cosmetic update
> >   libcamera: v4l2_device: Add support for META_CAPTURE devices
> >   libcamera: v4l2_device: Cosmetic update
> >
> >  src/libcamera/geometry.cpp             |  34 ++++++++
> >  src/libcamera/include/geometry.h       |  12 +++
> >  src/libcamera/include/v4l2_device.h    |  26 +++++-
> >  src/libcamera/include/v4l2_subdevice.h |  11 ++-
> >  src/libcamera/v4l2_device.cpp          |  92 ++++++++++++++-------
> >  src/libcamera/v4l2_subdevice.cpp       | 107 ++++++++++++++++++++++---
> >  test/v4l2_subdevice/list_formats.cpp   |  81 +++++++++++++++++++
> >  test/v4l2_subdevice/meson.build        |   1 +
> >  8 files changed, 321 insertions(+), 43 deletions(-)
> >  create mode 100644 test/v4l2_subdevice/list_formats.cpp
>
> --
> Regards,
>
> Laurent Pinchart