From patchwork Fri Mar 1 15:40:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 695 Return-Path: Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F0B5E610BF for ; Fri, 1 Mar 2019 16:40:41 +0100 (CET) X-Originating-IP: 2.224.242.101 Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 7633FC0015; Fri, 1 Mar 2019 15:40:41 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Fri, 1 Mar 2019 16:40:58 +0100 Message-Id: <20190301154103.19588-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v7 0/5] v4l2_(sub)dev: improvements and tests X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 15:40:42 -0000 Hello, few minor changes to address Laurent's comments. 1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY, I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE 2) remove method reordering in v4l2_device cosmetic patch 3) use std::vector.empty() instead of (std::vector.size() == 0) in list formats test. Hopefully this version might be pushed. Thanks j Jacopo Mondi (5): libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES test: v4l2_subdevice: Add ListFormat test libcamera: v4l2_subdevice: Cosmetic update libcamera: v4l2_device: Add support for META_CAPTURE devices libcamera: v4l2_device: Cosmetic update src/libcamera/geometry.cpp | 34 ++++++++ src/libcamera/include/geometry.h | 12 +++ src/libcamera/include/v4l2_device.h | 26 +++++- src/libcamera/include/v4l2_subdevice.h | 11 ++- src/libcamera/v4l2_device.cpp | 92 ++++++++++++++------- src/libcamera/v4l2_subdevice.cpp | 107 ++++++++++++++++++++++--- test/v4l2_subdevice/list_formats.cpp | 81 +++++++++++++++++++ test/v4l2_subdevice/meson.build | 1 + 8 files changed, 321 insertions(+), 43 deletions(-) create mode 100644 test/v4l2_subdevice/list_formats.cpp Reviewed-by: Laurent Pinchart --- 2.20.1