Patch Detail
Show a patch.
GET /api/patches/9621/?format=api
{ "id": 9621, "url": "https://patchwork.libcamera.org/api/patches/9621/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9621/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200915142038.28757-12-paul.elder@ideasonboard.com>", "date": "2020-09-15T14:20:26", "name": "[libcamera-devel,11/23] libcamera: IPAProxy: Add isolate parameter to create()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c85a04d7219e69320043568251387045ea2dbfd", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9621/mbox/", "series": [ { "id": 1291, "url": "https://patchwork.libcamera.org/api/series/1291/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1291", "date": "2020-09-15T14:20:16", "name": "IPA isolation implementation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1291/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9621/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9621/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7767BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Sep 2020 14:21:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90F9662E17;\n\tTue, 15 Sep 2020 16:21:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C21B162E1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Sep 2020 16:21:18 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A88FAEA;\n\tTue, 15 Sep 2020 16:21:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WKg2pIk3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600179678;\n\tbh=ILA9qGSrVUo7ScoEwEt/hWzj4MgFRkfuDHEvjOeEnOo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WKg2pIk35pnnN0DOoILADMQ6mwFhtxyyCY6X+KS/H/u1xYTr6sERNgQwNhFl/CF8Y\n\tye4NatSgMndU01QAT8M/NvW0VXhbo1MwuuPFW2xY8b4wuYuCOdFdFxEccwmtxSwaDI\n\tvFAP6cVGIIfuDkTHooNN1g6sElNkvZf9uQAInLSg=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Sep 2020 23:20:26 +0900", "Message-Id": "<20200915142038.28757-12-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "References": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 11/23] libcamera: IPAProxy: Add isolate\n\tparameter to create()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since IPAProxy implementations now always encapsulate IPA modules, add a\nparameter to create() to signal if the proxy should isolate the IPA or not.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/ipa_proxy.h | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex aec8f04f..1903150e 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -42,7 +42,7 @@ public:\n \tIPAProxyFactory(const char *name);\n \tvirtual ~IPAProxyFactory() {}\n \n-\tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n+\tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate) = 0;\n \n \tconst std::string &name() const { return name_; }\n \n@@ -53,16 +53,16 @@ private:\n \tstd::string name_;\n };\n \n-#define REGISTER_IPA_PROXY(proxy)\t\t\t\\\n-class proxy##Factory final : public IPAProxyFactory\t\\\n-{\t\t\t\t\t\t\t\\\n-public:\t\t\t\t\t\t\t\\\n-\tproxy##Factory() : IPAProxyFactory(#proxy) {}\t\\\n-\tstd::unique_ptr<IPAProxy> create(IPAModule *ipam)\t\\\n-\t{\t\t\t\t\t\t\\\n-\t\treturn std::make_unique<proxy>(ipam);\t\\\n-\t}\t\t\t\t\t\t\\\n-};\t\t\t\t\t\t\t\\\n+#define REGISTER_IPA_PROXY(proxy)\t\t\t\t\t\\\n+class proxy##Factory final : public IPAProxyFactory\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+public:\t\t\t\t\t\t\t\t\t\\\n+\tproxy##Factory() : IPAProxyFactory(#proxy) {}\t\t\t\\\n+\tstd::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate)\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\treturn std::make_unique<proxy>(ipam, isolate);\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+};\t\t\t\t\t\t\t\t\t\\\n static proxy##Factory global_##proxy##Factory;\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "11/23" ] }