Patch Detail
Show a patch.
GET /api/patches/9620/?format=api
{ "id": 9620, "url": "https://patchwork.libcamera.org/api/patches/9620/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9620/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200915142038.28757-11-paul.elder@ideasonboard.com>", "date": "2020-09-15T14:20:25", "name": "[libcamera-devel,10/23] libcamera: IPAProxy: Remove stop() override", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fa86ad9c1eb2f56683e2be12fcd1fb4fa478c87e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9620/mbox/", "series": [ { "id": 1291, "url": "https://patchwork.libcamera.org/api/series/1291/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1291", "date": "2020-09-15T14:20:16", "name": "IPA isolation implementation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1291/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9620/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9620/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F36FBF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Sep 2020 14:21:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D7EA62E30;\n\tTue, 15 Sep 2020 16:21:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DDA162E17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Sep 2020 16:21:16 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D54DA10C6;\n\tTue, 15 Sep 2020 16:21:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z0auLaYw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600179676;\n\tbh=3Tmzp3GTPNTq8PBgF2z8zvV2ry6agt6dvbi+OPuAp20=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Z0auLaYwbFsMakZg1CYs9IbWWJV/d0m2Etjti4/pCX4gZ+ba4zKAgP0f6c008h+2G\n\tPUObuSZ/Kr2T6SpfCcE7oIa9OU1nPaXumd0bhwtWUw0C3RxkEST0njgAFMOSeZ7mwm\n\tSbiJ7sND6T/F5J8O1T8HnhC/ywXPXxyo/e48T10k=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Sep 2020 23:20:25 +0900", "Message-Id": "<20200915142038.28757-11-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "References": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 10/23] libcamera: IPAProxy: Remove stop()\n\toverride", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since stop() is part of the IPA interface, and the IPA interface is now\ngenerated based on the data definition file per pipeline, this no longer\nneeds to be overrided by the base IPAProxy. Remove it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/ipa_proxy.h | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex b429ce5a..aec8f04f 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -27,8 +27,6 @@ public:\n \n \tstd::string configurationFile(const std::string &file) const;\n \n-\tvoid stop() override = 0;\n-\n protected:\n \tstd::string resolvePath(const std::string &file) const;\n \n", "prefixes": [ "libcamera-devel", "10/23" ] }