Patch Detail
Show a patch.
GET /api/patches/9136/?format=api
{ "id": 9136, "url": "https://patchwork.libcamera.org/api/patches/9136/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9136/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200803082359.592670-1-niklas.soderlund@ragnatech.se>", "date": "2020-08-03T08:23:59", "name": "[libcamera-devel,v2] libcamera: device_enumerator_udev: Initialize monitor_ and notifier_ to nullptr", "commit_ref": "108b6a8a15487b982612f34bd7b00e7b05be864a", "pull_url": null, "state": "accepted", "archived": false, "hash": "a35cf1efb37e79b25a492f948c21cfddcff9786b", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9136/mbox/", "series": [ { "id": 1179, "url": "https://patchwork.libcamera.org/api/series/1179/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1179", "date": "2020-08-03T08:23:59", "name": "[libcamera-devel,v2] libcamera: device_enumerator_udev: Initialize monitor_ and notifier_ to nullptr", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1179/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9136/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9136/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDD0CBD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2020 08:24:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8440360BF3;\n\tMon, 3 Aug 2020 10:24:09 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FF5860391\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2020 10:24:08 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid af735f86-d562-11ea-933e-005056917a89;\n\tMon, 03 Aug 2020 10:24:05 +0200 (CEST)" ], "X-Halon-ID": "af735f86-d562-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 Aug 2020 10:23:59 +0200", "Message-Id": "<20200803082359.592670-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2] libcamera: device_enumerator_udev:\n\tInitialize monitor_ and notifier_ to nullptr", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The monitor_ and notifier_ pointers are acted on in the destructor if\nnot set to nullptr, the pointers are however first initialized in\ninit() and enumerate(). Avoid acting on uninitialized pointers by\ninitializing them to nullptr in the constructor.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <email@uajain.com>\n---\n* Changes since v1\n- Update commit message\n---\n src/libcamera/device_enumerator_udev.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex 56ca4dc2804b46b9..96689daa5dd113dc 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -27,7 +27,7 @@ namespace libcamera {\n LOG_DECLARE_CATEGORY(DeviceEnumerator)\n \n DeviceEnumeratorUdev::DeviceEnumeratorUdev()\n-\t: udev_(nullptr)\n+\t: udev_(nullptr), monitor_(nullptr), notifier_(nullptr)\n {\n }\n \n", "prefixes": [ "libcamera-devel", "v2" ] }