[libcamera-devel,v2] libcamera: device_enumerator_udev: Initialize monitor_ and notifier_ to nullptr
diff mbox series

Message ID 20200803082359.592670-1-niklas.soderlund@ragnatech.se
State Accepted
Commit 108b6a8a15487b982612f34bd7b00e7b05be864a
Headers show
Series
  • [libcamera-devel,v2] libcamera: device_enumerator_udev: Initialize monitor_ and notifier_ to nullptr
Related show

Commit Message

Niklas Söderlund Aug. 3, 2020, 8:23 a.m. UTC 
The monitor_ and notifier_ pointers are acted on in the destructor if
not set to nullptr, the pointers are however first initialized in
init() and enumerate(). Avoid acting on uninitialized pointers by
initializing them to nullptr in the constructor.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <email@uajain.com>
---
* Changes since v1
- Update commit message
---
 src/libcamera/device_enumerator_udev.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox series 

diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp
index 56ca4dc2804b46b9..96689daa5dd113dc 100644
--- a/src/libcamera/device_enumerator_udev.cpp
+++ b/src/libcamera/device_enumerator_udev.cpp
@@ -27,7 +27,7 @@  namespace libcamera {
 LOG_DECLARE_CATEGORY(DeviceEnumerator)
 
 DeviceEnumeratorUdev::DeviceEnumeratorUdev()
-	: udev_(nullptr)
+	: udev_(nullptr), monitor_(nullptr), notifier_(nullptr)
 {
 }