Patch Detail
Show a patch.
GET /api/patches/9125/?format=api
{ "id": 9125, "url": "https://patchwork.libcamera.org/api/patches/9125/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9125/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200801080151.4282-2-david.plowman@raspberrypi.com>", "date": "2020-08-01T08:01:48", "name": "[libcamera-devel,v3,1/4] libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be atomic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b1978c475bea2a40a7f8c82ef7b9e185ff60c76c", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9125/mbox/", "series": [ { "id": 1174, "url": "https://patchwork.libcamera.org/api/series/1174/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1174", "date": "2020-08-01T08:01:47", "name": "Raspberry Pi ALSC improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1174/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9125/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9125/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DAFCBD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 1 Aug 2020 08:01:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1965561F41;\n\tSat, 1 Aug 2020 10:01:59 +0200 (CEST)", "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F62160394\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 1 Aug 2020 10:01:57 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id c19so493448wmd.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 01 Aug 2020 01:01:57 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl67sm17385253wml.13.2020.08.01.01.01.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 01 Aug 2020 01:01:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"A4UNMKW2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=;\n\tb=A4UNMKW2vZnDIe9HhJxFwjiEfbw7vHTvBrOaUc1AD0jSQPgQ0q2JTtrwcLHntnpPpD\n\t54ZSe62mTR+ytC8NN5y0FYozLrd+0OD08jiMUbiPf4ZSSxdwD/lLIABoEadXCrVpba7c\n\tmkCYfHqVkgarz7dEWRpI0jUEnCraw6BjvroT82dVgc3w1k/iL0M+vhXejxPKYI93fT6V\n\troOhZxg4SPnpfDy1Rw01FDrQ6RUpAGn4wezWkcY90SV/HDorJbpzlclQIwUFrY4ThPmS\n\tq7XJB0pDKa/9FGuxyalISM+R6xnITrWj9eK7ZbMHCaRERPxibMjE40EzQ1fnTXUyRxd2\n\t5nSA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=;\n\tb=s/ZRZmd8zZYSJa5aiVH6seMOqDc6wDEynafkF715X5dogYZ79abqu5fhSF1NT+GpJZ\n\tB98vZ34su0VT11L87zw6WVnKZ6naeO8WbxsCtnuihqXQ9F7dMP9luSOWEpSmwscgeJvw\n\tPG/5+mIYMtauRvX4eZiXHGLRWESQMiGC1ROx54cFG7HsOYZ9R1Sh1uSteOiaTRA0APOu\n\tkRaR5plMenKfUXJ6QenB8IyeyR67vIQwrYe2MlTPQ2iFS1xZCybRtHT0F6/YrXHzdCFY\n\tJusRZ8IzBZGtPraVmX/6/z2AkYr4Ym1wmyMfZqKjIKnTQjXeMZtDyc42TnW27cvgFivZ\n\tHw7g==", "X-Gm-Message-State": "AOAM531mOSRFXVdtom2iK+VJJrmOYNgtGHP1JP3VtadiTIC/FttQj74e\n\trfbY4cVgvKwYichP0nO/L2U7Z5GQOxPK+Q==", "X-Google-Smtp-Source": "ABdhPJy/hrMnXn9+LdartVHUYWzDG/btUshPe+H43HXTGh1+igT5oDMhD2BjQPc6cB7P4kkL1bITKQ==", "X-Received": "by 2002:a1c:3245:: with SMTP id y66mr6669328wmy.64.1596268916697;\n\tSat, 01 Aug 2020 01:01:56 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 1 Aug 2020 09:01:48 +0100", "Message-Id": "<20200801080151.4282-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200801080151.4282-1-david.plowman@raspberrypi.com>", "References": "<20200801080151.4282-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 1/4] libcamera: ipa: raspberrypi: ALSC:\n\tCamera mode does not need to be atomic", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In the libcamera framework, SwitchMode (which overwrites the\ncamera_mode) cannot run concurrently with Prepare (which uses it).\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\nindex 3806257..e895913 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n@@ -59,7 +59,7 @@ private:\n \t// configuration is read-only, and available to both threads\n \tAlscConfig config_;\n \tbool first_time_;\n-\tstd::atomic<CameraMode> camera_mode_;\n+\tCameraMode camera_mode_;\n \tstd::thread async_thread_;\n \tvoid asyncFunc(); // asynchronous thread function\n \tstd::mutex mutex_;\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }