From patchwork Sat Aug 1 08:01:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 9125 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7DAFCBD878 for ; Sat, 1 Aug 2020 08:01:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1965561F41; Sat, 1 Aug 2020 10:01:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="A4UNMKW2"; dkim-atps=neutral Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F62160394 for ; Sat, 1 Aug 2020 10:01:57 +0200 (CEST) Received: by mail-wm1-x342.google.com with SMTP id c19so493448wmd.1 for ; Sat, 01 Aug 2020 01:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=; b=A4UNMKW2vZnDIe9HhJxFwjiEfbw7vHTvBrOaUc1AD0jSQPgQ0q2JTtrwcLHntnpPpD 54ZSe62mTR+ytC8NN5y0FYozLrd+0OD08jiMUbiPf4ZSSxdwD/lLIABoEadXCrVpba7c mkCYfHqVkgarz7dEWRpI0jUEnCraw6BjvroT82dVgc3w1k/iL0M+vhXejxPKYI93fT6V roOhZxg4SPnpfDy1Rw01FDrQ6RUpAGn4wezWkcY90SV/HDorJbpzlclQIwUFrY4ThPmS q7XJB0pDKa/9FGuxyalISM+R6xnITrWj9eK7ZbMHCaRERPxibMjE40EzQ1fnTXUyRxd2 5nSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=; b=s/ZRZmd8zZYSJa5aiVH6seMOqDc6wDEynafkF715X5dogYZ79abqu5fhSF1NT+GpJZ B98vZ34su0VT11L87zw6WVnKZ6naeO8WbxsCtnuihqXQ9F7dMP9luSOWEpSmwscgeJvw PG/5+mIYMtauRvX4eZiXHGLRWESQMiGC1ROx54cFG7HsOYZ9R1Sh1uSteOiaTRA0APOu kRaR5plMenKfUXJ6QenB8IyeyR67vIQwrYe2MlTPQ2iFS1xZCybRtHT0F6/YrXHzdCFY JusRZ8IzBZGtPraVmX/6/z2AkYr4Ym1wmyMfZqKjIKnTQjXeMZtDyc42TnW27cvgFivZ Hw7g== X-Gm-Message-State: AOAM531mOSRFXVdtom2iK+VJJrmOYNgtGHP1JP3VtadiTIC/FttQj74e rfbY4cVgvKwYichP0nO/L2U7Z5GQOxPK+Q== X-Google-Smtp-Source: ABdhPJy/hrMnXn9+LdartVHUYWzDG/btUshPe+H43HXTGh1+igT5oDMhD2BjQPc6cB7P4kkL1bITKQ== X-Received: by 2002:a1c:3245:: with SMTP id y66mr6669328wmy.64.1596268916697; Sat, 01 Aug 2020 01:01:56 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id l67sm17385253wml.13.2020.08.01.01.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2020 01:01:56 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Sat, 1 Aug 2020 09:01:48 +0100 Message-Id: <20200801080151.4282-2-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200801080151.4282-1-david.plowman@raspberrypi.com> References: <20200801080151.4282-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 1/4] libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be atomic X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In the libcamera framework, SwitchMode (which overwrites the camera_mode) cannot run concurrently with Prepare (which uses it). Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart Reviewed-by: Naushir Patuck --- src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp index 3806257..e895913 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp @@ -59,7 +59,7 @@ private: // configuration is read-only, and available to both threads AlscConfig config_; bool first_time_; - std::atomic camera_mode_; + CameraMode camera_mode_; std::thread async_thread_; void asyncFunc(); // asynchronous thread function std::mutex mutex_;