Patch Detail
Show a patch.
GET /api/patches/8841/?format=api
{ "id": 8841, "url": "https://patchwork.libcamera.org/api/patches/8841/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8841/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200717085410.732308-4-naush@raspberrypi.com>", "date": "2020-07-17T08:54:03", "name": "[libcamera-devel,v3,03/10] libcamera: pipeline: raspberrypi: Add some debug logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6556ae99126d7e5905142182ad841022458d4870", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8841/mbox/", "series": [ { "id": 1114, "url": "https://patchwork.libcamera.org/api/series/1114/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1114", "date": "2020-07-17T08:54:00", "name": "Zero-copy RAW stream work", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1114/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8841/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8841/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78E05C0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Jul 2020 08:54:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 293F960545;\n\tFri, 17 Jul 2020 10:54:21 +0200 (CEST)", "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5196B6053B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jul 2020 10:54:18 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id f18so16014327wml.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jul 2020 01:54:18 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t92sm14582375wrr.96.2020.07.17.01.54.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jul 2020 01:54:17 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fISCSN/Y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mghvulaGFItXT09PwFBmybQhPdXVf6rjuYhUnND4iY4=;\n\tb=fISCSN/Y2n4WNlOqJ7X3BE+qxNvIx/W4DFIICMZjcYLrcWA+/a8YnE9cdg1v4ss/Kp\n\tXSwvLd/5+UHj/HntttSkFE39uwU+WcjK4weyIjRATcOao6mdcnG9ah6U9UpZYUwAg+Em\n\t0vOw3KqmsfazT2u9MHNyXBRccP1JUNStyorh51x+ftXkgSu1C9meymKHKgTtdubUz/4F\n\t/UJdcBi7ikB6z9cWltlG7xXn8BFk3+Z48j5gsPi3kxpEeUJCrIh8Q81fUdcc+b/vco6C\n\tuLL+aHliDSGBxDuV5ifIb1GQYxUUr10u8/ehzfUFHqC+REZhJlshvmauIqFtfg8SegYx\n\tBJAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mghvulaGFItXT09PwFBmybQhPdXVf6rjuYhUnND4iY4=;\n\tb=C++NzeCvhH4Xs1kP834wmpZ4IOFT+5eGZGd3K6Ooeql7avyBcMG1llvLDok50dE+HF\n\t9MSpY5xOXKUXm8VjdcXyPV2j6C7eRxqX3keAzR9nMn3DvKyE3gZFUhXVI8vOswxlUr9K\n\tYzCkQGRuqjumKtId0oTni4ypFpS2wG0d2cu2+7Rg2xU/teOMZPsxTFh/i/bhU3ijbXWY\n\tvIoidDWHp6w6oUTecmacM5cP6OPqyxEw+2sbh8FOJEF7tO4AxdQO7ripp+LhD71dJIvN\n\tg75YKsCaCqbpaW3Tfn1AvLhmHzIw0wp1w80Llvr43RlOfV3YOcQz9bD7WezVW+An3nTv\n\tALHQ==", "X-Gm-Message-State": "AOAM533olYIZxU6MFIOGOm3Ywk0d089deDLk7nxgkrfsnrSYLJUInJkv\n\tkunB+HpJzab3/9Ecb0OqX+jdJfUnLzo=", "X-Google-Smtp-Source": "ABdhPJzELYdE7rRFKaLk6p6ykzOcA/RELHJWCQ/d9lu1br/2PAy8lAwSPpuH/YILSNwJE77Ylrpz2Q==", "X-Received": "by 2002:a05:600c:241:: with SMTP id\n\t1mr8146150wmj.119.1594976057777; \n\tFri, 17 Jul 2020 01:54:17 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 17 Jul 2020 09:54:03 +0100", "Message-Id": "<20200717085410.732308-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200717085410.732308-1-naush@raspberrypi.com>", "References": "<20200717085410.732308-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 03/10] libcamera: pipeline:\n\traspberrypi: Add some debug logging", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 3884d93d..56b7ee99 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1183,6 +1183,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1347,6 +1352,8 @@ void RPiCameraData::checkRequestCompleted()\n \t\tpipe_->completeRequest(camera_, request);\n \t\trequestQueue_.pop_front();\n \t\trequestCompleted = true;\n+\n+\t\tLOG(RPI, Debug) << \"Request is complete\";\n \t}\n \n \t/*\n@@ -1485,7 +1492,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue<FrameBuffer *> &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n", "prefixes": [ "libcamera-devel", "v3", "03/10" ] }