From patchwork Fri Jul 17 08:54:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 8841 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 78E05C0109 for ; Fri, 17 Jul 2020 08:54:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 293F960545; Fri, 17 Jul 2020 10:54:21 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="fISCSN/Y"; dkim-atps=neutral Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5196B6053B for ; Fri, 17 Jul 2020 10:54:18 +0200 (CEST) Received: by mail-wm1-x342.google.com with SMTP id f18so16014327wml.3 for ; Fri, 17 Jul 2020 01:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mghvulaGFItXT09PwFBmybQhPdXVf6rjuYhUnND4iY4=; b=fISCSN/Y2n4WNlOqJ7X3BE+qxNvIx/W4DFIICMZjcYLrcWA+/a8YnE9cdg1v4ss/Kp XSwvLd/5+UHj/HntttSkFE39uwU+WcjK4weyIjRATcOao6mdcnG9ah6U9UpZYUwAg+Em 0vOw3KqmsfazT2u9MHNyXBRccP1JUNStyorh51x+ftXkgSu1C9meymKHKgTtdubUz/4F /UJdcBi7ikB6z9cWltlG7xXn8BFk3+Z48j5gsPi3kxpEeUJCrIh8Q81fUdcc+b/vco6C uLL+aHliDSGBxDuV5ifIb1GQYxUUr10u8/ehzfUFHqC+REZhJlshvmauIqFtfg8SegYx BJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mghvulaGFItXT09PwFBmybQhPdXVf6rjuYhUnND4iY4=; b=C++NzeCvhH4Xs1kP834wmpZ4IOFT+5eGZGd3K6Ooeql7avyBcMG1llvLDok50dE+HF 9MSpY5xOXKUXm8VjdcXyPV2j6C7eRxqX3keAzR9nMn3DvKyE3gZFUhXVI8vOswxlUr9K YzCkQGRuqjumKtId0oTni4ypFpS2wG0d2cu2+7Rg2xU/teOMZPsxTFh/i/bhU3ijbXWY vIoidDWHp6w6oUTecmacM5cP6OPqyxEw+2sbh8FOJEF7tO4AxdQO7ripp+LhD71dJIvN g75YKsCaCqbpaW3Tfn1AvLhmHzIw0wp1w80Llvr43RlOfV3YOcQz9bD7WezVW+An3nTv ALHQ== X-Gm-Message-State: AOAM533olYIZxU6MFIOGOm3Ywk0d089deDLk7nxgkrfsnrSYLJUInJkv kunB+HpJzab3/9Ecb0OqX+jdJfUnLzo= X-Google-Smtp-Source: ABdhPJzELYdE7rRFKaLk6p6ykzOcA/RELHJWCQ/d9lu1br/2PAy8lAwSPpuH/YILSNwJE77Ylrpz2Q== X-Received: by 2002:a05:600c:241:: with SMTP id 1mr8146150wmj.119.1594976057777; Fri, 17 Jul 2020 01:54:17 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id 92sm14582375wrr.96.2020.07.17.01.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 01:54:17 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 17 Jul 2020 09:54:03 +0100 Message-Id: <20200717085410.732308-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717085410.732308-1-naush@raspberrypi.com> References: <20200717085410.732308-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 03/10] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 3884d93d..56b7ee99 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1183,6 +1183,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1347,6 +1352,8 @@ void RPiCameraData::checkRequestCompleted() pipe_->completeRequest(camera_, request); requestQueue_.pop_front(); requestCompleted = true; + + LOG(RPI, Debug) << "Request is complete"; } /* @@ -1485,7 +1492,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;