Patch Detail
Show a patch.
GET /api/patches/8698/?format=api
{ "id": 8698, "url": "https://patchwork.libcamera.org/api/patches/8698/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8698/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200709084128.5316-8-jacopo@jmondi.org>", "date": "2020-07-09T08:41:15", "name": "[libcamera-devel,v2,07/20] libcamera: ipu3: Remove initialization of Size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8db25ed6256a76307879db2095ed45619ac9094a", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8698/mbox/", "series": [ { "id": 1091, "url": "https://patchwork.libcamera.org/api/series/1091/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1091", "date": "2020-07-09T08:41:08", "name": "libcamera: ipu3: Rework configuration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1091/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8698/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8698/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18166BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Jul 2020 08:38:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1BC46118C;\n\tThu, 9 Jul 2020 10:38:12 +0200 (CEST)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F31CB61169\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Jul 2020 10:38:10 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 7991310001A;\n\tThu, 9 Jul 2020 08:38:10 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Jul 2020 10:41:15 +0200", "Message-Id": "<20200709084128.5316-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200709084128.5316-1-jacopo@jmondi.org>", "References": "<20200709084128.5316-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 07/20] libcamera: ipu3: Remove\n\tinitialization of Size", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Size struct constructor defaults the width and height to 0.\nRemove the empty braced-list initialization as it is not required.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex d27acb405a1d..05e10ebb1a7d 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \t * only. If no resolution is requested for any stream, or if no sensor\n \t * resolution is large enough, pick the largest one.\n \t */\n-\tSize size = {};\n+\tSize size;\n \n \tfor (const StreamConfiguration &cfg : config_) {\n \t\tif (cfg.size.width > size.width)\n", "prefixes": [ "libcamera-devel", "v2", "07/20" ] }