| Message ID | 20200709084128.5316-8-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thanks for your work. On 2020-07-09 10:41:15 +0200, Jacopo Mondi wrote: > The Size struct constructor defaults the width and height to 0. > Remove the empty braced-list initialization as it is not required. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index d27acb405a1d..05e10ebb1a7d 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate() > * only. If no resolution is requested for any stream, or if no sensor > * resolution is large enough, pick the largest one. > */ > - Size size = {}; > + Size size; > > for (const StreamConfiguration &cfg : config_) { > if (cfg.size.width > size.width) > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Jacopo, Thank you for the patch. On Thu, Jul 09, 2020 at 10:41:15AM +0200, Jacopo Mondi wrote: > The Size struct constructor defaults the width and height to 0. > Remove the empty braced-list initialization as it is not required. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index d27acb405a1d..05e10ebb1a7d 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate() > * only. If no resolution is requested for any stream, or if no sensor > * resolution is large enough, pick the largest one. > */ > - Size size = {}; > + Size size; > > for (const StreamConfiguration &cfg : config_) { > if (cfg.size.width > size.width)
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index d27acb405a1d..05e10ebb1a7d 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate() * only. If no resolution is requested for any stream, or if no sensor * resolution is large enough, pick the largest one. */ - Size size = {}; + Size size; for (const StreamConfiguration &cfg : config_) { if (cfg.size.width > size.width)
The Size struct constructor defaults the width and height to 0. Remove the empty braced-list initialization as it is not required. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)