Patch Detail
Show a patch.
GET /api/patches/8437/?format=api
{ "id": 8437, "url": "https://patchwork.libcamera.org/api/patches/8437/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8437/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200626102531.1187650-3-naush@raspberrypi.com>", "date": "2020-06-26T10:25:29", "name": "[libcamera-devel,2/4] libcamera: ipa: raspberrypi: focus: Fix for uninitialised variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9fca29b096b23d99e5e5bfde3b99f50a0af703ef", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8437/mbox/", "series": [ { "id": 1044, "url": "https://patchwork.libcamera.org/api/series/1044/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1044", "date": "2020-06-26T10:25:27", "name": "Focus feedback control", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1044/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8437/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8437/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55045C0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2020 10:25:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA845609DB;\n\tFri, 26 Jun 2020 12:25:51 +0200 (CEST)", "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C5D8609A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2020 12:25:50 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id o2so8877887wmh.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2020 03:25:50 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tr8sm21959679wrp.40.2020.06.26.03.25.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2020 03:25:49 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"h9eDaAw/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ilBGmf7qx8NW1qoO21eVpclfnAKNglXLHtwud2JRoF4=;\n\tb=h9eDaAw/MnuzcGpm0aCszMToLbDX1eQcGiiwDPjB+U+6PXOai5WIOkJPA+lywwA0tj\n\t5A6NhQztsJF61J+DOyfTohfb07D/nimy+i9h7WA0RbziY70o6f+zefVkmRa6ld/v9Xvv\n\tdf8IRG/XjKG8KQ3SQBEWa+BxC2IVfdxJ6wRwmEXK5mq86Jce9RWsah7A9UtDqLYCFBng\n\tdwgeOCVqhlXk7+K66O4V0RDx9/j9rpsgh6K/MQ9w2MPcsuR5JirxFDXbBfBf7lTabNfX\n\tYlbMQwu/HqM7yP9agHX5G1lb99oBDiVmGIM/o927DLnLrA/3fhrvK8RFsCgqpJvIQ5nF\n\tiApA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ilBGmf7qx8NW1qoO21eVpclfnAKNglXLHtwud2JRoF4=;\n\tb=afWJXgwbpwtuq8MmuRalXlvBbq66Ik30GmHtPOfFEOEzc5VhN4njOW7432bX1lwxz7\n\tzvs2w1lTRRLf7zu/UfMvD6NLfBHccnd2cZUx7zLRQ7mb+NlVkTkMxWVaKFRHvGitc4kG\n\tF2iZPZc2Cf7febfWDkpm5mEizn0S5Tf2dYScw9qy0Hwh3Xz5Dx4HEgxLljcV0OUHiQIE\n\tN52ugDsZR384zKz0DgP+U3ccyGiS/t1P+cuaAyMITWvICQh3ivt3wNkmDttoHFexff0A\n\tCmpqrrTAq69gUaug5RzO6YREI84WIkgKju7Glt3zy+3kXRTT/CR2aRX6sLSv2b+B+a6d\n\tTRVg==", "X-Gm-Message-State": "AOAM531vakgdwPY30jVAa9dirWXksjg08vP/Het3prxdkd0DPgdV1vvA\n\tb4bSGwJ7FMvNWTggeakTibZwCcCkVCY=", "X-Google-Smtp-Source": "ABdhPJwhXSEJHabddSRZ5ZmBP62GNWRjsb9LAvA3+ns1VrGQyAsYlW+uxI5r1bNlE/aInCGDtKH+/A==", "X-Received": "by 2002:a05:600c:4109:: with SMTP id\n\tj9mr2536053wmi.157.1593167149979; \n\tFri, 26 Jun 2020 03:25:49 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Jun 2020 11:25:29 +0100", "Message-Id": "<20200626102531.1187650-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200626102531.1187650-1-naush@raspberrypi.com>", "References": "<20200626102531.1187650-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi: focus:\n\tFix for uninitialised variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Coverity static analysis check was reporting print_ was not initialised\nbefore being used in process(). Add an explicit initialiser for print_\nto the constructor.\n\nReported-by: Coverity CID=293456\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp\nindex 1e2b6491..4028ba56 100644\n--- a/src/ipa/raspberrypi/controller/rpi/focus.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n@@ -15,7 +15,7 @@ using namespace RPi;\n #define NAME \"rpi.focus\"\n \n Focus::Focus(Controller *controller)\n-\t: Algorithm(controller)\n+\t: Algorithm(controller), print_(false)\n {\n }\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }