From patchwork Fri Jun 26 10:25:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 8437 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 55045C0109 for ; Fri, 26 Jun 2020 10:25:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EA845609DB; Fri, 26 Jun 2020 12:25:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="h9eDaAw/"; dkim-atps=neutral Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C5D8609A9 for ; Fri, 26 Jun 2020 12:25:50 +0200 (CEST) Received: by mail-wm1-x342.google.com with SMTP id o2so8877887wmh.2 for ; Fri, 26 Jun 2020 03:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ilBGmf7qx8NW1qoO21eVpclfnAKNglXLHtwud2JRoF4=; b=h9eDaAw/MnuzcGpm0aCszMToLbDX1eQcGiiwDPjB+U+6PXOai5WIOkJPA+lywwA0tj 5A6NhQztsJF61J+DOyfTohfb07D/nimy+i9h7WA0RbziY70o6f+zefVkmRa6ld/v9Xvv df8IRG/XjKG8KQ3SQBEWa+BxC2IVfdxJ6wRwmEXK5mq86Jce9RWsah7A9UtDqLYCFBng dwgeOCVqhlXk7+K66O4V0RDx9/j9rpsgh6K/MQ9w2MPcsuR5JirxFDXbBfBf7lTabNfX YlbMQwu/HqM7yP9agHX5G1lb99oBDiVmGIM/o927DLnLrA/3fhrvK8RFsCgqpJvIQ5nF iApA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ilBGmf7qx8NW1qoO21eVpclfnAKNglXLHtwud2JRoF4=; b=afWJXgwbpwtuq8MmuRalXlvBbq66Ik30GmHtPOfFEOEzc5VhN4njOW7432bX1lwxz7 zvs2w1lTRRLf7zu/UfMvD6NLfBHccnd2cZUx7zLRQ7mb+NlVkTkMxWVaKFRHvGitc4kG F2iZPZc2Cf7febfWDkpm5mEizn0S5Tf2dYScw9qy0Hwh3Xz5Dx4HEgxLljcV0OUHiQIE N52ugDsZR384zKz0DgP+U3ccyGiS/t1P+cuaAyMITWvICQh3ivt3wNkmDttoHFexff0A CmpqrrTAq69gUaug5RzO6YREI84WIkgKju7Glt3zy+3kXRTT/CR2aRX6sLSv2b+B+a6d TRVg== X-Gm-Message-State: AOAM531vakgdwPY30jVAa9dirWXksjg08vP/Het3prxdkd0DPgdV1vvA b4bSGwJ7FMvNWTggeakTibZwCcCkVCY= X-Google-Smtp-Source: ABdhPJwhXSEJHabddSRZ5ZmBP62GNWRjsb9LAvA3+ns1VrGQyAsYlW+uxI5r1bNlE/aInCGDtKH+/A== X-Received: by 2002:a05:600c:4109:: with SMTP id j9mr2536053wmi.157.1593167149979; Fri, 26 Jun 2020 03:25:49 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id r8sm21959679wrp.40.2020.06.26.03.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 03:25:49 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 26 Jun 2020 11:25:29 +0100 Message-Id: <20200626102531.1187650-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626102531.1187650-1-naush@raspberrypi.com> References: <20200626102531.1187650-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi: focus: Fix for uninitialised variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Coverity static analysis check was reporting print_ was not initialised before being used in process(). Add an explicit initialiser for print_ to the constructor. Reported-by: Coverity CID=293456 Signed-off-by: Naushir Patuck Reviewed-by: David Plowman --- src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp index 1e2b6491..4028ba56 100644 --- a/src/ipa/raspberrypi/controller/rpi/focus.cpp +++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp @@ -15,7 +15,7 @@ using namespace RPi; #define NAME "rpi.focus" Focus::Focus(Controller *controller) - : Algorithm(controller) + : Algorithm(controller), print_(false) { }