Patch Detail
Show a patch.
GET /api/patches/821/?format=api
{ "id": 821, "url": "https://patchwork.libcamera.org/api/patches/821/?format=api", "web_url": "https://patchwork.libcamera.org/patch/821/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190329111307.16656-1-jacopo@jmondi.org>", "date": "2019-03-29T11:13:07", "name": "[libcamera-devel] libcamera: stream: Qualify 'Camera' friend directive", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ebad4ae808f48eb77e901c32fc13f23b512883f8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/821/mbox/", "series": [ { "id": 223, "url": "https://patchwork.libcamera.org/api/series/223/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=223", "date": "2019-03-29T11:13:07", "name": "[libcamera-devel] libcamera: stream: Qualify 'Camera' friend directive", "version": 1, "mbox": "https://patchwork.libcamera.org/series/223/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/821/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/821/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9CFC600FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Mar 2019 12:12:32 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 47B2020015;\n\tFri, 29 Mar 2019 11:12:31 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Mar 2019 12:13:07 +0100", "Message-Id": "<20190329111307.16656-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: stream: Qualify 'Camera'\n\tfriend directive", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 29 Mar 2019 11:12:33 -0000" }, "content": "Align the Stream class to all other classes in the code base to use the\n'class' qualifier in 'friend' declarations.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/stream.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.21.0", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 24407cb65361..970c479627fa 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -29,7 +29,7 @@ public:\n \tconst StreamConfiguration &configuration() const { return configuration_; }\n\n private:\n-\tfriend Camera;\n+\tfriend class Camera;\n\n \tBufferPool bufferPool_;\n \tStreamConfiguration configuration_;\n", "prefixes": [ "libcamera-devel" ] }