[libcamera-devel] libcamera: stream: Qualify 'Camera' friend directive

Message ID 20190329111307.16656-1-jacopo@jmondi.org
State Accepted
Headers show
Series
  • [libcamera-devel] libcamera: stream: Qualify 'Camera' friend directive
Related show

Commit Message

Jacopo Mondi March 29, 2019, 11:13 a.m. UTC
Align the Stream class to all other classes in the code base to use the
'class' qualifier in 'friend' declarations.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 include/libcamera/stream.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.21.0

Comments

Laurent Pinchart March 29, 2019, 2:37 p.m. UTC | #1
Hi Jacopo,

Thank you for the patch.

On Fri, Mar 29, 2019 at 12:13:07PM +0100, Jacopo Mondi wrote:
> Align the Stream class to all other classes in the code base to use the
> 'class' qualifier in 'friend' declarations.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/libcamera/stream.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h
> index 24407cb65361..970c479627fa 100644
> --- a/include/libcamera/stream.h
> +++ b/include/libcamera/stream.h
> @@ -29,7 +29,7 @@ public:
>  	const StreamConfiguration &configuration() const { return configuration_; }
> 
>  private:
> -	friend Camera;
> +	friend class Camera;
> 
>  	BufferPool bufferPool_;
>  	StreamConfiguration configuration_;

Patch

diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h
index 24407cb65361..970c479627fa 100644
--- a/include/libcamera/stream.h
+++ b/include/libcamera/stream.h
@@ -29,7 +29,7 @@  public:
 	const StreamConfiguration &configuration() const { return configuration_; }

 private:
-	friend Camera;
+	friend class Camera;

 	BufferPool bufferPool_;
 	StreamConfiguration configuration_;