Patch Detail
Show a patch.
GET /api/patches/3869/?format=api
{ "id": 3869, "url": "https://patchwork.libcamera.org/api/patches/3869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>", "date": "2020-05-28T12:30:05", "name": "[libcamera-devel] libcamera: test: Fixed the compilation issue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cc1f36defe2160335ad602b625c313abcbd5e3f7", "submitter": { "id": 29, "url": "https://patchwork.libcamera.org/api/people/29/?format=api", "name": "Madhavan Krishnan", "email": "madhavan.krishnan@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3869/mbox/", "series": [ { "id": 932, "url": "https://patchwork.libcamera.org/api/series/932/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=932", "date": "2020-05-28T12:30:05", "name": "[libcamera-devel] libcamera: test: Fixed the compilation issue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/932/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3869/checks/", "tags": {}, "headers": { "Return-Path": "<madhavan.krishnan@linaro.org>", "Received": [ "from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D73AA603D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 May 2020 14:30:48 +0200 (CEST)", "by mail-wr1-x442.google.com with SMTP id y17so19306960wrn.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 May 2020 05:30:48 -0700 (PDT)", "from mmwg-hackbox.linaro.org.de ([2a01:4f8:10a:2685::2])\n\tby smtp.gmail.com with ESMTPSA id\n\tx8sm5678624wrs.43.2020.05.28.05.30.47\n\t(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 May 2020 05:30:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"IryrGZFw\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=6hNb58pbGD0sNxaA0IAqHSvAC19TahwG9pEHMp+cM5E=;\n\tb=IryrGZFw02zGlB/zp4NT0NyqAv/9tjnVucOr6mRJxF00uVJpMzg9FmCW0tkcjw2zxi\n\tftdAavmtT0V7L282Lo5J3fuaO+SUMSylGw8jCQgvWPTF1XT9pEOF+ycy8BSzCTEjv9RC\n\t6zw+aiEf15KMxyoqeHRsXgXLgaOMm248uzoZlKlbpWVJvFoqCcuh3hDL9DLVVi/CMYQZ\n\t6r9jGgIvPPPRXNNQdJqbE3HjlK+ZzgXFNC7B5BGs+QIPOU68C4DIKUHJu1YhIYe+0PkW\n\tUvtLn+hex9Vr1HPWibdh262Mmrri+nqYmzpd8N6ZBtelMK69HA7vNL/MHXokEwWKQPYz\n\tacIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=6hNb58pbGD0sNxaA0IAqHSvAC19TahwG9pEHMp+cM5E=;\n\tb=tB8AeJ1RShPb9/RF9Xdgb1zINadqTaUcgZVoFqduPo8BZVZktB2QkumsH1YhMQff8y\n\ty8JurMInU9UIBqgml4oK0DZtyivI4NQE+oR4NFCjHqgCRGBWEwqRunEC4TSeb6VP3MM7\n\t7kG+cABrOxwRyBvUuXV2flr8obAvH663wlBI2ALNiBaBhrCVWliA7lDPY1sBfwqbrMgG\n\tONEALt3zHZ9BWQUkmuxdK7/GClw9Shr7Y4MB857G8TL2q+9/1otw304bGNxtQ7IaPQTY\n\t20ysE+crXfc8sAXPMqLFR94Lldadzq9VaKHZ+77hfNl2DL5b/ONZeeTH7kpZTONdIqCl\n\tG9Ww==", "X-Gm-Message-State": "AOAM531m1B/Y6IyPeO1NdG0+xaU5JCCifnwIglUx8/D0JSnX0FBvAXQ9\n\ts6G5j5XWBS/dSbRJv6YDlveq06Dyej0=", "X-Google-Smtp-Source": "ABdhPJw0bUhMAsO5ibvy8We/SjHuzDOe+Q1hYpX++fAnMno5YGeygfIN2Q3gH1IPZB5pqYkOOe90jg==", "X-Received": "by 2002:adf:dd01:: with SMTP id a1mr3323168wrm.224.1590669048169;\n\tThu, 28 May 2020 05:30:48 -0700 (PDT)", "From": "Madhavan Krishnan <madhavan.krishnan@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Madhavan Krishnan <madhavan.krishnan@linaro.org>", "Date": "Thu, 28 May 2020 14:30:05 +0200", "Message-Id": "<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<libcamera: Fixed the compilation issue>", "References": "<libcamera: Fixed the compilation issue>", "Subject": "[libcamera-devel] [PATCH] libcamera: test: Fixed the compilation\n\tissue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 May 2020 12:30:49 -0000" }, "content": "In write() function, return value is not handled and stored.\nSo, we faced the compilation issue regarding this.\n\nHandled to store the return value of write() function, and\nmodified the test execution based on the return values.\n\nSigned-off-by: Madhavan Krishnan <madhavan.krishnan@linaro.org>\n---\n test/file.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/file.cpp b/test/file.cpp\nindex 6262a6f..85eacb5 100644\n--- a/test/file.cpp\n+++ b/test/file.cpp\n@@ -27,10 +27,15 @@ protected:\n \t{\n \t\tfileName_ = \"/tmp/libcamera.test.XXXXXX\";\n \t\tint fd = mkstemp(&fileName_.front());\n+\t\tssize_t ret;\n+\n \t\tif (fd == -1)\n \t\t\treturn TestFail;\n \n-\t\twrite(fd, \"libcamera\", 9);\n+\t\tret = write(fd, \"libcamera\", 9);\n+\t\tif(ret == -1)\n+\t\t\treturn TestFail;\n+\n \t\tclose(fd);\n \n \t\treturn TestPass;\n", "prefixes": [ "libcamera-devel" ] }