From patchwork Thu May 28 12:30:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Krishnan X-Patchwork-Id: 3869 Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D73AA603D3 for ; Thu, 28 May 2020 14:30:48 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="IryrGZFw"; dkim-atps=neutral Received: by mail-wr1-x442.google.com with SMTP id y17so19306960wrn.11 for ; Thu, 28 May 2020 05:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6hNb58pbGD0sNxaA0IAqHSvAC19TahwG9pEHMp+cM5E=; b=IryrGZFw02zGlB/zp4NT0NyqAv/9tjnVucOr6mRJxF00uVJpMzg9FmCW0tkcjw2zxi ftdAavmtT0V7L282Lo5J3fuaO+SUMSylGw8jCQgvWPTF1XT9pEOF+ycy8BSzCTEjv9RC 6zw+aiEf15KMxyoqeHRsXgXLgaOMm248uzoZlKlbpWVJvFoqCcuh3hDL9DLVVi/CMYQZ 6r9jGgIvPPPRXNNQdJqbE3HjlK+ZzgXFNC7B5BGs+QIPOU68C4DIKUHJu1YhIYe+0PkW UvtLn+hex9Vr1HPWibdh262Mmrri+nqYmzpd8N6ZBtelMK69HA7vNL/MHXokEwWKQPYz acIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6hNb58pbGD0sNxaA0IAqHSvAC19TahwG9pEHMp+cM5E=; b=tB8AeJ1RShPb9/RF9Xdgb1zINadqTaUcgZVoFqduPo8BZVZktB2QkumsH1YhMQff8y y8JurMInU9UIBqgml4oK0DZtyivI4NQE+oR4NFCjHqgCRGBWEwqRunEC4TSeb6VP3MM7 7kG+cABrOxwRyBvUuXV2flr8obAvH663wlBI2ALNiBaBhrCVWliA7lDPY1sBfwqbrMgG ONEALt3zHZ9BWQUkmuxdK7/GClw9Shr7Y4MB857G8TL2q+9/1otw304bGNxtQ7IaPQTY 20ysE+crXfc8sAXPMqLFR94Lldadzq9VaKHZ+77hfNl2DL5b/ONZeeTH7kpZTONdIqCl G9Ww== X-Gm-Message-State: AOAM531m1B/Y6IyPeO1NdG0+xaU5JCCifnwIglUx8/D0JSnX0FBvAXQ9 s6G5j5XWBS/dSbRJv6YDlveq06Dyej0= X-Google-Smtp-Source: ABdhPJw0bUhMAsO5ibvy8We/SjHuzDOe+Q1hYpX++fAnMno5YGeygfIN2Q3gH1IPZB5pqYkOOe90jg== X-Received: by 2002:adf:dd01:: with SMTP id a1mr3323168wrm.224.1590669048169; Thu, 28 May 2020 05:30:48 -0700 (PDT) Received: from mmwg-hackbox.linaro.org.de ([2a01:4f8:10a:2685::2]) by smtp.gmail.com with ESMTPSA id x8sm5678624wrs.43.2020.05.28.05.30.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2020 05:30:47 -0700 (PDT) From: Madhavan Krishnan To: libcamera-devel@lists.libcamera.org Cc: Madhavan Krishnan Date: Thu, 28 May 2020 14:30:05 +0200 Message-Id: <1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Subject: [libcamera-devel] [PATCH] libcamera: test: Fixed the compilation issue X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2020 12:30:49 -0000 In write() function, return value is not handled and stored. So, we faced the compilation issue regarding this. Handled to store the return value of write() function, and modified the test execution based on the return values. Signed-off-by: Madhavan Krishnan Reported-by: Coverity CID=284605 Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- test/file.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/file.cpp b/test/file.cpp index 6262a6f..85eacb5 100644 --- a/test/file.cpp +++ b/test/file.cpp @@ -27,10 +27,15 @@ protected: { fileName_ = "/tmp/libcamera.test.XXXXXX"; int fd = mkstemp(&fileName_.front()); + ssize_t ret; + if (fd == -1) return TestFail; - write(fd, "libcamera", 9); + ret = write(fd, "libcamera", 9); + if(ret == -1) + return TestFail; + close(fd); return TestPass;