Patch Detail
Show a patch.
GET /api/patches/3625/?format=api
{ "id": 3625, "url": "https://patchwork.libcamera.org/api/patches/3625/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3625/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200430011709.22801-1-laurent.pinchart@ideasonboard.com>", "date": "2020-04-30T01:17:09", "name": "[libcamera-devel] libcamera: Build IPA module signatures by default", "commit_ref": "25a101846d02af48c53109038a891f2aeb1ac8db", "pull_url": null, "state": "accepted", "archived": false, "hash": "6a0592e104a78f04b1095206e662106de758c9e2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3625/mbox/", "series": [ { "id": 857, "url": "https://patchwork.libcamera.org/api/series/857/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=857", "date": "2020-04-30T01:17:09", "name": "[libcamera-devel] libcamera: Build IPA module signatures by default", "version": 1, "mbox": "https://patchwork.libcamera.org/series/857/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3625/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3625/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB152603F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 03:17:13 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B4B9503\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 03:17:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lfsJyOKK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588209433;\n\tbh=BfgpC4LEHnYEpUX3RDYbYV1nWPChGLkjLeK5MyaBEYY=;\n\th=From:To:Subject:Date:From;\n\tb=lfsJyOKKXQhLr4tIjsTnSJrEw+FpWKp/npZxJ1isnuk3LI3CBBZExO86fvKjXjpgE\n\tCx75wTrha2sejYn/QRdXAqeVycOwPmprY+83Vhb8MsAj17pyMSjquDDDawSKh0+oz9\n\tWdAm9AcSBfnrryVRmuXPL9ziBR8h8OXh/OlFBH2o=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Apr 2020 04:17:09 +0300", "Message-Id": "<20200430011709.22801-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Build IPA module signatures by\n\tdefault", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 30 Apr 2020 01:17:14 -0000" }, "content": "Commit 7206035ee609 (\"libcamera: Regenerate IPA module signatures at\ninstall time\") replaced installation of the IPA module signatures with\nan install script that signs all modules. While doing so, it\ninadvertently also disabled generation of the signature at build time by\ndefault. This breaks running libcamera binaries from the build\ndirectory. Fix it.\n\nFixes: 7206035ee609 (\"libcamera: Regenerate IPA module signatures at install time\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/meson.build | 3 ++-\n src/ipa/vimc/meson.build | 3 ++-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\nindex 6c6aa82f3b29..d7127ea8d1e9 100644\n--- a/src/ipa/rkisp1/meson.build\n+++ b/src/ipa/rkisp1/meson.build\n@@ -14,5 +14,6 @@ if ipa_sign_module\n input : mod,\n output : ipa_name + '.so.sign',\n command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n- install : false)\n+ install : false,\n+ build_by_default : true)\n endif\ndiff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\nindex 253847e19d6b..22296a029642 100644\n--- a/src/ipa/vimc/meson.build\n+++ b/src/ipa/vimc/meson.build\n@@ -14,7 +14,8 @@ if ipa_sign_module\n input : mod,\n output : ipa_name + '.so.sign',\n command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n- install : false)\n+ install : false,\n+ build_by_default : true)\n endif\n \n subdir('data')\n", "prefixes": [ "libcamera-devel" ] }