From patchwork Thu Apr 30 01:17:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3625 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EB152603F3 for ; Thu, 30 Apr 2020 03:17:13 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lfsJyOKK"; dkim-atps=neutral Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B4B9503 for ; Thu, 30 Apr 2020 03:17:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1588209433; bh=BfgpC4LEHnYEpUX3RDYbYV1nWPChGLkjLeK5MyaBEYY=; h=From:To:Subject:Date:From; b=lfsJyOKKXQhLr4tIjsTnSJrEw+FpWKp/npZxJ1isnuk3LI3CBBZExO86fvKjXjpgE Cx75wTrha2sejYn/QRdXAqeVycOwPmprY+83Vhb8MsAj17pyMSjquDDDawSKh0+oz9 WdAm9AcSBfnrryVRmuXPL9ziBR8h8OXh/OlFBH2o= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Thu, 30 Apr 2020 04:17:09 +0300 Message-Id: <20200430011709.22801-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.25.3 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: Build IPA module signatures by default X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 01:17:14 -0000 Commit 7206035ee609 ("libcamera: Regenerate IPA module signatures at install time") replaced installation of the IPA module signatures with an install script that signs all modules. While doing so, it inadvertently also disabled generation of the signature at build time by default. This breaks running libcamera binaries from the build directory. Fix it. Fixes: 7206035ee609 ("libcamera: Regenerate IPA module signatures at install time") Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- src/ipa/rkisp1/meson.build | 3 ++- src/ipa/vimc/meson.build | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build index 6c6aa82f3b29..d7127ea8d1e9 100644 --- a/src/ipa/rkisp1/meson.build +++ b/src/ipa/rkisp1/meson.build @@ -14,5 +14,6 @@ if ipa_sign_module input : mod, output : ipa_name + '.so.sign', command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ], - install : false) + install : false, + build_by_default : true) endif diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build index 253847e19d6b..22296a029642 100644 --- a/src/ipa/vimc/meson.build +++ b/src/ipa/vimc/meson.build @@ -14,7 +14,8 @@ if ipa_sign_module input : mod, output : ipa_name + '.so.sign', command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ], - install : false) + install : false, + build_by_default : true) endif subdir('data')