Patch Detail
Show a patch.
GET /api/patches/3252/?format=api
{ "id": 3252, "url": "https://patchwork.libcamera.org/api/patches/3252/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3252/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323142205.28342-10-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T14:21:53", "name": "[libcamera-devel,09/21] qcam: main_window: Don't print message when saving a picture", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c292b3f34f1b85f0d0e7d784b7c122966d909eb4", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3252/mbox/", "series": [ { "id": 760, "url": "https://patchwork.libcamera.org/api/series/760/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=760", "date": "2020-03-23T14:21:44", "name": "qcam: Bypass format conversion when not required", "version": 1, "mbox": "https://patchwork.libcamera.org/series/760/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3252/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3252/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74F4B62C68\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:21 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F99DA31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:21 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584973341;\n\tbh=9klAwUZMv+hh1pYubVMeghSnO3MNPDsYBfzap4LhRVc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ljqJOrHoLO44nV7lRkWs8pI7VTjtfr+EZR7zqpw7A0uRjsVR2jrafub7Mm9Kk/WsR\n\tZitI8neap6fmuMYj3yAx3d1GT6LSaXUPUelqqBqwrZAOIP/IVrJEq2wGPQ0ATzapvm\n\t8MQUvkaLS9qtexFFPA7RvsoEb68bK1dPtu4J3Bjc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 16:21:53 +0200", "Message-Id": "<20200323142205.28342-10-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 09/21] qcam: main_window: Don't print\n\tmessage when saving a picture", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 14:22:24 -0000" }, "content": "When saving a picture, the application prints a message on cout. This\nisn't necessary and doesn't really help with debugging or diagnostics,\nremove it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 18aae07ffce7..7aaa73e9a709 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -406,9 +406,6 @@ void MainWindow::saveImageAs()\n \n \tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n-\n-\tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n-\n \tif (filename.isEmpty())\n \t\treturn;\n \n", "prefixes": [ "libcamera-devel", "09/21" ] }